A handful of fc changes to support unix sockets for HTTP RPC #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When implementing unix socket HTTP support in websocketpp I tried to make as few changes to websocketpp as possible. Unfortuately still need to add a friend class in here it seems.
fc::mutable_url was never implemented; so remove the deceiving declaration of it. Add a way to piecemeal construct an fc::url by a long argument list in its place. I need to construct an fc::url with something that isn't quite a real URL so I need a way to set each piece manually.
Unix paths handed to the http_client contain the socket path and url path concatenated together. http_client needs to discover what portion is the socket path and what portion is the url path. This information is then cached for later usage.
jgiszczak
reviewed
Aug 17, 2018
src/network/http/http_client.cpp
Outdated
| Unix URLs work a little special here. They'll originally be in the format of | ||
| unix:///home/spoonincode/eosio-wallet/keosd.sock/v1/wallet/sign_digest | ||
| for example. When the fc::url is given to http_client in post_sync(), this will | ||
| have proto=unix and host=/home/spoonincode/eosio-wallet/keosd.sock/v1/wallet/sign_digest |
There was a problem hiding this comment.
I don't follow? obviously (or, at least I thought obviously) that comment is meant to be an example
There was a problem hiding this comment.
In the context of Github, it obviously is an example. In bare source code, I didn't think it was completely obvious that 'spoonincode' is someone's username.
host=/home/username/eosio-wallet/keosd.sock/v1/wallet/sign_digest is more generic. Likewise for two lines above.
jgiszczak
reviewed
Aug 17, 2018
src/network/http/http_client.cpp
Outdated
| At this point we still don't know what part of the above string is the unix socket path | ||
| and which part is the path to access on the server. This function discovers that | ||
| host=/home/spoonincode/eosio-wallet/keosd.sock and path=/v1/wallet/sign_digest | ||
| and create another fc::url that will be used downstream of the http_client::post_sync() |
wanderingbort
approved these changes
Aug 20, 2018
jgiszczak
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the handful of changes I made to fc to support unix socket endpoints for HTTP RPC between keosd & cleos/nodeos. Most of these are pretty straightforward so I'd recommend reading each commit piecemeal.