Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: decrease bundle size of jsonform #590

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

StefanBrand
Copy link
Member

Instead of importing the bundle, import the module, which allows tree-shaking.

Ref. json-editor/json-editor#1470

Before

dist/eox-jsonform.js  828.19 kB │ gzip: 144.86 kB
dist/eox-jsonform.umd.cjs  596.59 kB │ gzip: 127.46 kB

After

dist/eox-jsonform.js  421.60 kB │ gzip: 86.46 kB
dist/eox-jsonform.umd.cjs  328.16 kB │ gzip: 74.71 kB

Copy link
Collaborator

@silvester-pari silvester-pari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this!

@silvester-pari silvester-pari merged commit cd9837c into main Jan 18, 2024
3 checks passed
@silvester-pari silvester-pari deleted the jsonform/chore/decrease-bundle-size branch January 18, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants