Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RotateForLoops] Add unit tests to loop rotation pass #27

Open
lucas-rami opened this issue Aug 20, 2023 · 0 comments
Open

[RotateForLoops] Add unit tests to loop rotation pass #27

lucas-rami opened this issue Aug 20, 2023 · 0 comments
Labels
enhancement Improvement to existing feature of Dynamatic nice-to-have Cosmetic and/or light improvements to the framework

Comments

@lucas-rami
Copy link
Member

A recent commit (aa8eca2) improved the for loop rotation pass to let it handle loops with negative bounds. This generalization makes at least one of our standard benchmark (sobel) yield a better circuit because two additional loops of the original source code are able to be matched and converted by our pass.

The pass currently lacks some unit tests, which is obviously not ideal. We should add some and, at the same time, take the opportunity to rename the TableGen-defined pass to ScfRotateForLoops (replacing ScfForLoopRotation) to follow standard pass naming conventions.

@lucas-rami lucas-rami added enhancement Improvement to existing feature of Dynamatic nice-to-have Cosmetic and/or light improvements to the framework labels Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing feature of Dynamatic nice-to-have Cosmetic and/or light improvements to the framework
Projects
None yet
Development

No branches or pull requests

1 participant