Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Explorer current branch ribbon feature #104

Merged
merged 8 commits into from
Apr 17, 2020
Merged

File Explorer current branch ribbon feature #104

merged 8 commits into from
Apr 17, 2020

Conversation

jettseale
Copy link
Collaborator

  • Added ribbon to File Explorer card that shows the current branch of the selected directory, or "Untracked" if not tracked by Git version control.
  • Branch ribbon text has a bounded scroll animation from left to right on mouse hover.
  • Branch ribbon text fades back to its original position once the mouse is no longer hovering on the ribbon.
  • Branch ribbon text fades in on File Explorer card load.

@jettseale jettseale requested a review from nelsonni April 17, 2020 04:49
@nelsonni nelsonni added this to the v1.0.0 milestone Apr 17, 2020
@nelsonni nelsonni linked an issue Apr 17, 2020 that may be closed by this pull request
File Explorer card #54
Closed
4 tasks
@nelsonni nelsonni added the feature Feature requests or improvements label Apr 17, 2020
nelsonni
nelsonni requested changes Apr 17, 2020
View reviewed changes
Copy link
Member

@nelsonni nelsonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality and tests look good. There are a few minor change requests for improving code quality and consistency.

src/components/FileExplorer.tsx Outdated Show resolved Hide resolved
src/components/FileExplorer.tsx Outdated Show resolved Hide resolved
src/assets/style.css Outdated Show resolved Hide resolved
@nelsonni nelsonni merged commit 21434ce into development Apr 17, 2020
@nelsonni nelsonni deleted the feature/branch-ribbon branch April 17, 2020 23:06
@nelsonni nelsonni mentioned this pull request Apr 17, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonni nelsonni nelsonni approved these changes

Assignees
No one assigned
Labels
feature Feature requests or improvements
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

File Explorer card
2 participants
@jettseale @nelsonni