-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreedomFaighter patch 2 #66
Closed
FreedomFaighter
wants to merge
22
commits into
EQAditu:master
from
FreedomFaighter:FreedomFaighter-patch-2
Closed
FreedomFaighter patch 2 #66
FreedomFaighter
wants to merge
22
commits into
EQAditu:master
from
FreedomFaighter:FreedomFaighter-patch-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents where possible and removed explicit closings.
swapped the zero value check of the crit count to before the percentage calculations as exception will be thrown if percentage calculations are done with crit value of zero
Same as change to English parser
Updated AttackTypeGetCritTypes to create copy of the list as Data object passed by reference can be modified mid method call and throw exception for current iteration of counting critical attack types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.