[G2M] Plotly/improve sizing #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vxsl
force-pushed
the
plotly/improve-sizing
branch
from
c3e9801
to
5ee5add
Compare
vxsl
force-pushed
the
plotly/improve-sizing
branch
6 times, most recently
from
f60acb6
to
6e64a20
Compare
vxsl
force-pushed
the
plotly/improve-sizing
branch
from
6e64a20
to
7ea8f6c
Compare
vxsl
force-pushed
the
plotly/improve-sizing
branch
from
267d1a7
to
257f2a4
Compare
vxsl
force-pushed
the
plotly/improve-sizing
branch
from
257f2a4
to
068f2c3
Compare
sallkall
approved these changes
Jan 28, 2022
geoerika
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency for EQWorks/widget-studio#68
integrated vanilla
plotly.jsusing solution from On hooks plotly/react-plotly.js#242, removing the need for thereact-plotly.jslibrary altogether. This package didn't provide any additional functionality and was keeping us locked below the most current plotly version.generally reworked the way that plots are sized, should be more predictable and performant
added special logic for pie charts to not render the titles too far away from the actual visualization.
before:
after:
deps
added
react-resize-detectorremoved
react-plotly.js