Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CLUBB-MF functionality on trunk #181

Closed
adamrher opened this issue Aug 6, 2020 · 0 comments
Closed

Implement CLUBB-MF functionality on trunk #181

adamrher opened this issue Aug 6, 2020 · 0 comments
Labels
enhancement New feature or request externals externals updating issue or PR

Comments

@adamrher
Copy link

adamrher commented Aug 6, 2020

This issue is associated with the CPT to test / implement CLUBB-MF (MF = mass fluxes) into CAM, in coordination with JPL / UCLA & NCAR (@mikaelwitte, @JulioTBacmeister)

After meeting with @gold2718, it was decided that an efficient way to develop the CLUBB-MF functionality is to develop a minimally functional version that can be turned off, and merge it with the trunk ASAP. Since this code touches multiple CAM externals, as well as the CAM source code itself, Steve has outlined the steps required to close this issue:

  1. Open issues describing the work on ESCOMP/CAM, ESCOMP/CLUBB, and ESCOMP/PUMAS.
  2. Do the work necessary to implement the new scheme, at least partially.
  3. When the code can be turned off, submit PRs for CLUBB and PUMAS.
  4. When CLUBB and PUMAS have been merged and tagged, submit a PR back to cam_development.
  5. The CAM PR should have a (probably single column) test to protect the new EDMF functionality.

Our thinking is that the FSCAM test will be the BOMEX IOP, and I will reach out to Steve for assistance in developing this test when the time comes.

I currently have forked / branches for ESCOMP/CLUBB (clubb_release_b76a124.clubb-mf) and ESCOMP/PUMAS (pumas_cam-release_v1.3.clubb-mf). These are branches of the tags currently pointed to in Externals_CAM.cfg in the latest cam tag (as of now, cam6_2_039). I have a forked branch of cam6_2_039 that points to these new externals (cam6_2_039.clubb-mf). Depending on how long it takes to complete these tasks, I may have to consider updating to a later cam tag to expedite the cam PR (Im not sure how burdensome it is to be a few tags behind, so please advise when appropriate).

Future issues will be associated with further developing the CLUBB-MF code, primarily major coding / testing milestones that the CPT group feel should be merged with the trunk.

@adamrher adamrher added enhancement New feature or request externals externals updating issue or PR labels Aug 6, 2020
@nusbaume nusbaume closed this as completed Dec 3, 2020
gdicker1 pushed a commit to gdicker1/CAM that referenced this issue Oct 13, 2022
Description of changes

Explicitly put GRIS (for Greenland Ice Sheet) in the long name. This
shouldn't change any behavior. CISM has been backwards compatible in
this respect, but making this compset long name change will allow us to
remove the backwards compatibility code in CISM.
Specific notes

Contributors other than yourself, if any: none

Fixes ESCOMP#181

User interface changes?: No

Testing performed (automated tests and/or manual tests):

    Ran create_newcase with each of the changed compsets (but didn't run any further than that)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request externals externals updating issue or PR
Projects
Status: Done
Development

No branches or pull requests

2 participants