Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify naming and attributes of time variables on history files to be consistent with other CESM components #554 #554

Closed
phillips-ad opened this issue Mar 30, 2022 · 3 comments
Assignees
Labels
CoupledEval3 enhancement New feature or request
Milestone

Comments

@phillips-ad
Copy link

These changes are being requested to improve the ease-of-access of CESM data and to normalize the look of the metadata across CESM components. See ESCOMP/CESM#194 and especially the google doc referenced from ESCOMP/CESM#194 (comment).

Current CAM time array output:

double time(time) ;
	time:long_name = "time" ;
	time:units = "days since YYYY-MM-DD HH:MM:SS" ;
	time:calendar = "noleap" ;
	time:bounds = "time_bnds" ;
double time_bnds(time, nbnd) ;
	time_bnds:long_name = "time interval endpoints" ;

Proposed CAM time array output:

double time(time) ;
	time:long_name = "time" ;
	time:units = "days since YYYY-MM-DD HH:MM:SS" ;
	time:calendar = "noleap" ;
	time:bounds = "time_bounds" ;
double time_bounds(time, nbnd) ;
	time_bounds:long_name = "time interval endpoints" ;
	time_bounds:units = "days since YYYY-MM-DD HH:MM:SS" ;
	time_bounds:calendar = "noleap" ;

Changes made: time_bnds renamed as time_bounds, added units/calendar attributes to time_bounds, change bounds attribute of time to time_bounds

@billsacks @phillips-ad @strandwg are filing similar issues for each component.

@gold2718
Copy link
Collaborator

gold2718 commented Apr 5, 2022

This request (arising from ESCOMP/CESM#194?) mentions time and time_bndstime_bounds.
What about the related variables in CAM history files?

  • date (int, "current date (YYYYMMDD)")
  • datesec (int, "current seconds of current date")

Does anyone use these fields? Do they need to match time? @phillips-ad? @billsacks? @nusbaume?

@nusbaume
Copy link
Collaborator

nusbaume commented Apr 5, 2022

@gold2718 I am not aware of any current usage for date and datesec in the ADF, but I'll ping that group to see if anyone uses those fields in general, and if it would be beneficial for them to have it match time.

@phillips-ad
Copy link
Author

phillips-ad commented Apr 6, 2022

@gold2718 that's a great catch. I for one do use the date variable as no conversion is necessary to read it (using ncdump for example). Yes, if we shift time to the center of the averaging period, date/datesec also needs to be shifted to align with the centered time. I will add this to #159.

@gold2718 gold2718 assigned gold2718 and unassigned cacraigucar May 2, 2022
@cacraigucar cacraigucar changed the title Modify naming and attributes of time variables on history files to be consistent with other CESM components Modify naming and attributes of time variables on history files to be consistent with other CESM components #554 May 2, 2022
@nusbaume nusbaume assigned peverwhee and unassigned gold2718 Sep 18, 2023
@nusbaume nusbaume closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CoupledEval3 enhancement New feature or request
Projects
Status: Done
Status: Done (or no longer holding things up)
Development

No branches or pull requests

5 participants