Change "time" value for averaged quantities to midpoint of averaging period #869

peverwhee · 2023-08-03T18:48:16Z

Overview

Per #159 - this PR changes the "time" variable in a history file with averaged (and/or min/max/stdev quantities) to be the midpoint of the averaging period (basically, the average of the time_bounds variable).

Side affects of the above/related changes in this PR (all implemented):

Instantaneous history files (avgflag_pertape = 'I') cannot have averaged fields due to the time mismatch
Averaged history files (avgflag_pertape /= 'I') cannot have instantaneous fields (same reason)
Changed 'time_bnds' variable name to 'time_bounds'
Ensured the 'cell_methods' metadata field always includes "time: XXXXX" (where XXXXX refers to the avgflag) for history fields so that it's always clear what operation is being done on/for that field

Tests performed locally

Tested out-of-the-box Kessler (h0 is instantaneous) - runs and time field is current time
Tested trying to add an average field to h0 - fails as expected
Tested adding an average tape (h1) - runs and time field is midpoint(s)
Tested adding an instantaneous field to h1 - fails as expected
Tested adding instantaneous field (":I") to h0 and average field (":M") to h1 - works as expected

Related to: ESCOMP/CTSM#2019

closes #159

…rules

peverwhee · 2023-08-04T22:57:45Z

Requesting @fvitt take a look at the updated WACCM use case namelists

fvitt

Some suggestions

fvitt · 2023-08-05T00:44:21Z

bld/namelist_files/use_cases/1950-2010_ccmi_refc1_waccmx_ma.xml

+<avgflag_pertape> 'A',  'I',  'I',  'A',  'A', 'A', 'I'  </avgflag_pertape>
+<nhtfrq>            0,   -1,  -24,  -24, -120, -24, -120 </nhtfrq>
+<mfilt>             1,   24,    7,    7,   10, 365,  10  </mfilt>


Suggested change

<avgflag_pertape> 'A', 'I', 'I', 'A', 'A', 'A', 'I' </avgflag_pertape>

<nhtfrq> 0, -1, -24, -24, -120, -24, -120 </nhtfrq>

<mfilt> 1, 24, 7, 7, 10, 365, 10 </mfilt>

<avgflag_pertape> 'A', 'I', 'I', 'A', 'A', 'A', 'A', 'I' </avgflag_pertape>

<nhtfrq> 0, -1, -24, -24, -120, -24, -24, -120 </nhtfrq>

<mfilt> 1, 24, 7, 7, 10, 365, 365, 73 </mfilt>

changed, though I did not add the extra average history tape and instead changed the existing tape numbers in the finclx variables.

fvitt · 2023-08-05T00:45:45Z

bld/namelist_files/use_cases/sd_waccm_ma_cam4.xml

@@ -87,7 +87,7 @@
 <!-- History Streams -->

 <mfilt>             1,  30, 120, 240, 240, 480, 365,  73,  30  </mfilt>


Suggested change

<mfilt> 1, 30, 120, 240, 240, 480, 365, 73, 30 </mfilt>

<mfilt> 1, 30, 120, 240, 240, 480, 365, 73, 73 </mfilt>

fvitt · 2023-08-05T00:46:25Z

bld/namelist_files/use_cases/sd_waccm_ma_cam6.xml

@@ -67,7 +67,7 @@
 <!-- History Streams -->

 <mfilt>             1,  30, 120, 240, 240, 480, 365,  73,  30  </mfilt>


Suggested change

<mfilt> 1, 30, 120, 240, 240, 480, 365, 73, 30 </mfilt>

<mfilt> 1, 30, 120, 240, 240, 480, 365, 73, 73 </mfilt>

fvitt · 2023-08-05T00:49:53Z

bld/namelist_files/use_cases/sd_waccm_sulfur.xml

@@ -118,7 +118,7 @@
  'BRO:B', 'NO3:B', 'DTCORE:B', 'DTV:B', 'TTGW:B','OMEGA:B' </fincl3>
 <!-- Daily Average -->
 <fincl4>
-  'PS', 'PSL', 'U', 'V', 'T', 'Z3', 'PHIS','FRONTGF:I', 'OMEGA'
+  'PS', 'PSL', 'U', 'V', 'T', 'Z3', 'PHIS','FRONTGF', 'OMEGA'


Move 'FRONTGF' to fincl6

fvitt · 2023-08-05T00:54:45Z

bld/namelist_files/use_cases/sd_waccmx_ma_cam6.xml

-</fincl8>
+</fincl7>
+<!-- Instantaneous every 5 days -->
+<fincl8>'FRONTGF'</fincl8>


Set the 8th entry of nhtfrq to -120 and mfilt to 73 in this use case.

fvitt · 2023-08-05T01:01:26Z

bld/namelist_files/use_cases/waccm_tsmlt_2010_cam6.xml

@@ -146,8 +146,8 @@

 <!-- History Files -->

-<mfilt>           1,    5,  20,  40, 120, 240, 365,  73, 365   </mfilt>
-<nhtfrq>          0,  -24,  -6,  -3,  -1,   1, -24,-120,-240  </nhtfrq>
+<mfilt>           1,    5,  20,  40, 120, 240, 365,  73, 365  </mfilt>


Suggested change

<mfilt> 1, 5, 20, 40, 120, 240, 365, 73, 365 </mfilt>

<mfilt> 1, 5, 20, 40, 120, 240, 365, 73, 73 </mfilt>

fvitt · 2023-08-05T01:01:49Z

bld/namelist_files/use_cases/waccm_tsmlt_hist_cam6.xml

@@ -42,8 +42,8 @@

 <!-- History Files -->

-<mfilt>           1,    5,  20,  40, 120, 240, 365,  73, 365   </mfilt>
-<nhtfrq>          0,  -24,  -6,  -3,  -1,   1, -24,-120,-240  </nhtfrq>
+<mfilt>           1,    5,  20,  40, 120, 240, 365,  73, 365  </mfilt>


Suggested change

<mfilt> 1, 5, 20, 40, 120, 240, 365, 73, 365 </mfilt>

<mfilt> 1, 5, 20, 40, 120, 240, 365, 73, 73 </mfilt>

fvitt · 2023-08-05T01:04:10Z

bld/namelist_files/use_cases/waccmx_ma_2000_cam4.xml

@@ -136,7 +136,7 @@
  'SAD_ICE', 'SAD_LNAT', 'SAD_SULFC', 'T', 'TREFHT', 'TTGW', 'U',
  'UTGWORO', 'UTGWSPEC', 'V', 'VERT', 'VTGWORO', 'VTGWSPEC', 'Z3', 'O2_1S', 'O2_1D', 'NOX', 'NOY',
  'CLOX', 'CLOY', 'BROX', 'BROY', 'TCLY', 'TOTH', 'QJOULE', 'UIONTEND', 'VIONTEND',
-  'DTCORE', 'CLDLIQ', 'CLDICE', 'CONCLD', 'FRONTGF:I', 'BUTGWSPEC', 'BTAUE', 'BTAUW', 'BTAUN', 'BTAUS', 'TAUE',
+  'DTCORE', 'CLDLIQ', 'CLDICE', 'CONCLD', 'FRONTGF', 'BUTGWSPEC', 'BTAUE', 'BTAUW', 'BTAUN', 'BTAUS', 'TAUE',


Should move 'FRONTGF' to fincl4 which should be designated as 'I'

moved and changed.

fvitt · 2023-08-05T01:05:53Z

bld/namelist_files/use_cases/waccmx_ma_2000_cam6.xml

@@ -78,7 +78,7 @@
         'Z3', 'T', 'TIon', 'TElec', 'e', 'U', 'V', 'OMEGA', 'UI', 'VI', 'WI', 'ElecColDens', 'PHIM2D', 'PS',
         'PED_CONDUCTANCE', 'HALL_CONDUCTANCE', 'ED1', 'ED2', 'O', 'O2', 'H', 'NO', 'CO2', 'N', 'O1D',
 	 'Op2P', 'Op2D', 'Op', 'Np', 'N2p', 'O2p', 'NOp', 'QJOULE', 'SIGMAHAL', 'SIGMAPED', 'SolIonRate_Tot',
-	 'Z3GM', 'OpDens', 'EDens'
+	 'Z3GM', 'OpDens', 'EDens', 'FRONTGF'


'FRONTGF' should be moved to fincl4

moved and changed

fvitt · 2023-08-05T01:06:34Z

bld/namelist_files/use_cases/waccmxie_ma_2000_cam4.xml

@@ -114,7 +114,7 @@
         'QRL_TOT', 'PSL', 'HNO3_STS', 'HNO3_NAT', 'HNO3_GAS', 'NO_Aircraft', 'NO_Lightning',
         'QRS_AUR', 'QRS_CO2NIR', 'QRS_EUV', 'SAD_ICE', 'SAD_LNAT', 'SAD_SULFC', 'TREFHT',
         'VERT', 'VTGWORO', 'VTGWSPEC', 'O2_1S', 'O2_1D', 'NOX', 'NOY', 'CLOX', 'CLOY', 'BROX', 'BROY',
-	 'TCLY', 'TOTH', 'UIONTEND', 'VIONTEND', 'DTCORE', 'CLDLIQ', 'CLDICE', 'CONCLD', 'FRONTGF:I',
+	 'TCLY', 'TOTH', 'UIONTEND', 'VIONTEND', 'DiTCORE', 'CLDLIQ', 'CLDICE', 'CONCLD',


Suggested change

'TCLY', 'TOTH', 'UIONTEND', 'VIONTEND', 'DiTCORE', 'CLDLIQ', 'CLDICE', 'CONCLD',

'TCLY', 'TOTH', 'UIONTEND', 'VIONTEND', 'DTCORE', 'CLDLIQ', 'CLDICE', 'CONCLD',

Courtney Peverley and others added 3 commits August 1, 2023 13:47

remove support for instantaneous fields on h0

758a276

prohibit averaged fields on instantaneous tapes

d2aa746

code cleanup

f68519b

peverwhee self-assigned this Aug 3, 2023

peverwhee added this to Open PRs - unassigned in CAM Development branch (cutting edge development) via automation Aug 3, 2023

Courtney Peverley added 3 commits August 3, 2023 12:58

Merge remote-tracking branch 'ESCOMP/cam_development' into HEAD

127e170

remove erroneous check; update usermod configurations to reflect new …

52dbc15

…rules

update use_cases - previous commit was actually test cases

488e3a1

peverwhee requested a review from fvitt August 4, 2023 22:57

fvitt requested changes Aug 5, 2023

View reviewed changes

fix errors; change mfilt for 5-day file to 73

adc2082

peverwhee requested a review from fvitt August 7, 2023 17:57

peverwhee marked this pull request as draft August 8, 2023 15:37

cacraigucar added the CoupledEval3 label Aug 21, 2023

peverwhee closed this Oct 13, 2023

CAM Development branch (cutting edge development) automation moved this from Open PRs - unassigned to Completed tags Oct 13, 2023

peverwhee mentioned this pull request Oct 13, 2023

cam6_3_140: Separate history tapes into hXi and hXa #903

Merged

peverwhee removed the CoupledEval3 label Jan 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change "time" value for averaged quantities to midpoint of averaging period #869

Change "time" value for averaged quantities to midpoint of averaging period #869

peverwhee commented Aug 3, 2023

peverwhee commented Aug 4, 2023

fvitt left a comment

fvitt Aug 5, 2023

peverwhee Aug 7, 2023

fvitt Aug 5, 2023

peverwhee Aug 7, 2023

fvitt Aug 5, 2023

peverwhee Aug 7, 2023

fvitt Aug 5, 2023

peverwhee Aug 7, 2023

fvitt Aug 5, 2023

peverwhee Aug 7, 2023

fvitt Aug 5, 2023

peverwhee Aug 7, 2023

fvitt Aug 5, 2023

peverwhee Aug 7, 2023

fvitt Aug 5, 2023

peverwhee Aug 7, 2023

fvitt Aug 5, 2023

peverwhee Aug 7, 2023

fvitt Aug 5, 2023

peverwhee Aug 7, 2023

		@@ -87,7 +87,7 @@
		<!-- History Streams -->

		<mfilt> 1, 30, 120, 240, 240, 480, 365, 73, 30 </mfilt>

		@@ -67,7 +67,7 @@
		<!-- History Streams -->

		<mfilt> 1, 30, 120, 240, 240, 480, 365, 73, 30 </mfilt>

	<mfilt> 1, 5, 20, 40, 120, 240, 365, 73, 365 </mfilt>
	<mfilt> 1, 5, 20, 40, 120, 240, 365, 73, 73 </mfilt>

	'TCLY', 'TOTH', 'UIONTEND', 'VIONTEND', 'DiTCORE', 'CLDLIQ', 'CLDICE', 'CONCLD',
	'TCLY', 'TOTH', 'UIONTEND', 'VIONTEND', 'DTCORE', 'CLDLIQ', 'CLDICE', 'CONCLD',

Change "time" value for averaged quantities to midpoint of averaging period #869

Change "time" value for averaged quantities to midpoint of averaging period #869

Conversation

peverwhee commented Aug 3, 2023

Overview

Tests performed locally

peverwhee commented Aug 4, 2023

fvitt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment