Remove unused testmods directories #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fischer-ncar
requested changes
Oct 17, 2018
There was a problem hiding this comment.
I also wanted to make sure that @jedwards4b doesn't need the trilinos testmods.
|
I do not. |
|
@fischer-ncar - thanks - see ESMCI/cime#2862 |
fischer-ncar
approved these changes
Oct 17, 2018
|
@billsacks do you want to remove these testsmods from cesm2.1-alphabranch too? |
|
@fischer-ncar thanks for checking. I figured it was more important to remove these from master, and I didn't take the time to look into whether they were used at all on cesm2.1-alphabranch. I'd be happy with their removal there, too, if they are unused there as well, if you have time to check if that's okay. |
fischer-ncar
added a commit
to ESMCI/cime
that referenced
this pull request
Oct 18, 2018
Remove reference to deleted testmods directories Companion to ESCOMP/CESM#84 Test suite: none Test baseline: n/a Test namelist changes: n/a Test status: bit for bit Fixes none User interface changes?: N Update gh-pages html (Y/N)?: Y Code review:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bit of cleanup: As far as I can tell, these testmods directories are unused.
User interface changes?: No
Fixes: None
Testing: None