Add shr_dust_emis_mod to handle options for dust emissions between CTSM and CAM #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekluzek
added
enhancement
|
@fvitt I haven't got this working or tested yet in CTSM. But, I think this includes everything needed in this space. So if you could look it over and give feedback that would be great. I'll be working on completing this to bring this in the next month or so... |
8 tasks
…o allows me to do unit-testing easier
…is_mod Conflicts: cesm/nuopc_cap_share/shr_dust_emis_mod.F90
Change check_if_initiatlized to logical function to help with unit testing.
Make the checking of options it's own subroutine to help with unit-testing.
This was referenced May 9, 2024
ekluzek
changed the title
|
This is ready to come in from my perspective at this point. I'm happy to hear about any changes or testing that I need to do with it though. And I figure this will have to wait until after the cesm3_0_beta01 freeze in case something is needed from CMEPS for the git fleximod update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add a shared module for controlling how dust emissions are handled in CTSM and CAM.
This will allow us to use the current dust emission options, and also the new dust emissions
being developed.
This implements the design given for this work in:
https://docs.google.com/document/d/18nZ3LJF5W-YF9iBhqed6s_NWeKOvSSL2-k0Lye1nnLg/edit#heading=h.c1sjcqnqh1zs
Specific notes
Contributors other than yourself, if any: @fvitt
CMEPS Issues Fixed (include github issue #):
Fixes #353
Are changes expected to change answers? No
Any User Interface Changes (namelist or namelist defaults changes)?
Namelist items added the drv_fls_in namelist:
These will be set by either CAM or CTSM to control how dust emissions work.
Testing performed
None so far. But, will do standard testing in CTSM as well as any CMEPS test lists.
This shouldn't effect anything outside of CTSM and CAM, and even then only for
versions that use it.