Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes an issue with symbols in compset names on derecho #444

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

jedwards4b
Copy link
Collaborator

Description of changes

Fixes an issue when running create_test with a full compset name that contains special characters like %.

Specific notes

I changed the call to the Makefile from buildexe to use a relative path instead of full path, this seems to
have addressed the issue.

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing

@jedwards4b jedwards4b self-assigned this Mar 27, 2024
Copy link
Contributor

@briandobbins briandobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's odd that we don't know the direct connection with GNU make and special characters (I still suspect the locale settings), but if this works in practice, passing our tests, that works for me.

@jedwards4b jedwards4b merged commit e884e50 into ESCOMP:main Mar 28, 2024
2 checks passed
@jedwards4b jedwards4b deleted the fix/symbolsincompsetname branch March 28, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants