Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to increase min_snow_to_keep #1425

Closed
billsacks opened this issue Jul 10, 2021 · 1 comment
Closed

Need to increase min_snow_to_keep #1425

billsacks opened this issue Jul 10, 2021 · 1 comment
Assignees
@billsacks
Labels
priority: high High priority task to fix soon, e.g., because it is a problem in important configurations tag: good first issue good for first-time contributors type: bug something is working incorrectly
Projects
High priority Upcoming tags

Comments

@billsacks
Copy link
Member

Brief summary of bug

A user reported an issue with the snow pack going slightly negative. The problem seems to be that the min_snow_to_keep parameter in SnowHydrologyMod is too small (1e-9). There is no reason why it needs to be so small. I suggest increasing min_snow_to_keep to 1e-3. This may change answers.

General bug information

CTSM version you are using: master

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: Rare

Details of bug

See https://bb.cgd.ucar.edu/cesm/threads/spin-up-shut-down-problem-and-low-resolution-of-totecosysc-nee-gpp-results.6286 for details.
@billsacks billsacks added tag: good first issue good for first-time contributors type: bug something is working incorrectly labels Jul 10, 2021
@billsacks billsacks added the priority: high High priority task to fix soon, e.g., because it is a problem in important configurations label Jul 28, 2021
@billsacks billsacks added this to Needs triage in High priority via automation Jul 28, 2021
@billsacks billsacks self-assigned this Jul 28, 2021
@billsacks
Copy link
Member Author

I'm raising the priority of this because others have run into this issue, too.

@billsacks billsacks moved this from Needs triage to To do in High priority Jul 29, 2021
@billsacks billsacks added this to In progress - master in Upcoming tags Aug 11, 2021
@billsacks billsacks moved this from To do to In progress in High priority Aug 12, 2021
billsacks added a commit that referenced this issue Aug 13, 2021
@billsacks
Merge branch 'antarctica_compset'
93749b9 
Add Antarctica compset and change min_snow_to_keep

(1) Add a compset for running CISM with Antarctica

(2) Change min_snow_to_keep (see
    #1425 for details)

Resolves #1425 (Need to increase min_snow_to_keep)
Upcoming tags automation moved this from In progress - master to Master Tags/Issues Done Aug 13, 2021
High priority automation moved this from In progress to Done Aug 13, 2021
glemieux added a commit to glemieux/ctsm that referenced this issue Aug 16, 2021
@glemieux
Merge tag 'ctsm5.1.dev053' into SP_api_merge_dev053
4816360 
Add Antarctica compset and change min_snow_to_keep

(1) Add a compset for running CISM with Antarctica

(2) Change min_snow_to_keep (see
    ESCOMP#1425 for details)
ekluzek added a commit to djk2120/CTSM that referenced this issue Aug 18, 2021
@ekluzek
Merge tag 'ctsm5.1.dev053' into medlyn_sms
cdf2779 
Add Antarctica compset and change min_snow_to_keep

(1) Add a compset for running CISM with Antarctica

(2) Change min_snow_to_keep (see
    ESCOMP#1425 for details)
ekluzek added a commit to olyson/ctsm that referenced this issue Aug 18, 2021
@ekluzek
Merge tag 'ctsm5.1.dev053' into hardcodep2
60ecfb5 
Add Antarctica compset and change min_snow_to_keep

(1) Add a compset for running CISM with Antarctica

(2) Change min_snow_to_keep (see
    ESCOMP#1425 for details)
slevis-lmwg pushed a commit to slevis-lmwg/ctsm that referenced this issue Aug 19, 2021
Merge tag 'ctsm5.1.dev053' into hist_vars_for_newton_krylov
695f85c 
Add Antarctica compset and change min_snow_to_keep

(1) Add a compset for running CISM with Antarctica

(2) Change min_snow_to_keep (see
    ESCOMP#1425 for details)
slevis-lmwg pushed a commit to slevis-lmwg/ctsm that referenced this issue Aug 24, 2021
Merge tag 'ctsm5.1.dev053' into vert_res_in_mimics
bae1162 
Add Antarctica compset and change min_snow_to_keep

(1) Add a compset for running CISM with Antarctica

(2) Change min_snow_to_keep (see
    ESCOMP#1425 for details)

Resolved Conflicts:
doc/ChangeLog
doc/ChangeSum
ekluzek added a commit to chrislxj/ctsm that referenced this issue Dec 15, 2021
@ekluzek
Merge tag 'ctsm5.1.dev053' into cn-matrix_v3
fc39915 
Add Antarctica compset and change min_snow_to_keep

(1) Add a compset for running CISM with Antarctica

(2) Change min_snow_to_keep (see
    ESCOMP#1425 for details)

 Conflicts:
	cime_config/buildnml
	src/biogeochem/CNPrecisionControlMod.F90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billsacks billsacks

Labels
priority: high High priority task to fix soon, e.g., because it is a problem in important configurations tag: good first issue good for first-time contributors type: bug something is working incorrectly
Projects
High priority
Done
Upcoming tags
Done (non release/external)
Milestone
No milestone
Development

No branches or pull requests
1 participant
@billsacks