Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with smallville for latest datasets... #203

Closed
billsacks opened this issue Dec 29, 2017 · 3 comments
Closed

Issue with smallville for latest datasets... #203

billsacks opened this issue Dec 29, 2017 · 3 comments
Labels
type: bug something is working incorrectly

Comments

@billsacks
Copy link
Member

From @ekluzek on May 1, 2017 0:29

This comes up for ERP_Lm20_Mmpi-serial.1x1_smallvilleIA.ICLM45BGCCROP.yellowstone_pgi.clm-monthly

when new surface dataset is used and an updated finidat file interpolated from...

fsurdat = '/glade/p/cesmdata/cseg/inputdata/lnd/clm2/surfdata_map/surfdata_1x1_smallvilleIA_78pfts_simyr2000_c170412.nc'
[erik@yslogin5 scripts]$ grep finidat ERP_Lm20_Mmpi-serial.1x1_smallvilleIA.ICLM45BGCCROP.yellowstone_pgi.clm-monthly.GC.latestfil02_r23545pgi/CaseDocs/lnd_in
finidat = '/glade/p/cesmdata/cseg/inputdata/lnd/clm2/initdata_map/clmi.ICLM45BGCCROP.78pfts.levis_reinterpII.1.9x2.5_g1v6_simyr2000_c170216.nc
use_init_interp = .true.

nstep = 22490 TS = 279.575795847494248
nstep = 22491 TS = 280.940981977393960
(shr_dmodel_readLBUB) file ub: /glade/p/cesmdata/cseg/inputdata/atm/datm7/NASA_LIS/clmforc.Li_2012_climo1995-2011.T62.lnfm_Total_c140423.nc 830
nbalance warning 4 -1.4411518807585587E+017
1.0416666267607461E+033
inputs,ffix,nfix,ndep = 0.000000000000000 0.000000000000000
7.1360665356088945E-005
outputs,lch,roff,dnit = 6.8891626385430399E-004 0.000000000000000
1.1323804569220714E-006
column nbalance error = -1.4411518807585587E+017 4
Latdeg,Londeg = 40.68780000000000
267.0228000000000
begnb = 2534.067095773820
endnb = 1.0416666267607461E+033
delta store = 1.0416666267607461E+033
input mass = 1.0416666267607459E+033
output mass = 1.2314397945952904E-003
net flux = 1.0416666267607459E+033
inputs,ffix,nfix,ndep = 0.000000000000000
0.000000000000000 7.1360665356088945E-005
outputs,ffix,nfix,ndep = 6.8891626385430399E-004
0.000000000000000 1.1323804569220714E-006
ENDRUN:
ERROR in /glade/p/work/erik/clm_latestclm50datasets/components/clm/src/biogeochem/CNBalanceCheckMod.F90 at line 351
ERROR: Unknown error submitted to shr_sys_abort.

Copied from original issue: NCAR/CLM#5
@billsacks
Copy link
Member Author

From @ekluzek on May 1, 2017 0:35

Comparing this to the standard clm4_5_15_r235 test case, the difference is the fsurdat file, and the fact that finidat=' ' is used in the standard case, and use_init_interp=T and the new finidat file is used in this case.

@billsacks billsacks added the type: bug something is working incorrectly label Feb 9, 2018
@billsacks
Copy link
Member Author

This looks like a duplicate of #158

@billsacks billsacks added the closed: duplicate Issue already reported, or changes included in a different PR label May 20, 2020
@billsacks
Copy link
Member Author

Actually, I think there are two separate (though related) issues in #158 - one is with the creation of the landuse timeseries file for smallville (fails in mksurfdata_map), and the other is an issue with incorrect fields on the surface dataset when running a non-transient smallville case (fails at runtime due to a balance error), which is documented in this issue. While it's possible that a single change could fix both issues, I think there's a simpler fix for for the surface dataset / balance issue, so I'll keep this issue open to deal with that one.

@billsacks billsacks reopened this May 20, 2020
@billsacks billsacks mentioned this issue May 20, 2020
Closed
billsacks added a commit to billsacks/ctsm that referenced this issue May 20, 2020
@billsacks
Change issue associated with smallville test failure
bb3f8e8 
I think it's really ESCOMP#203 that's causing this failure, not
ESCOMP#158.
billsacks added a commit to billsacks/ctsm that referenced this issue May 20, 2020
@billsacks
Initialize harvest variables to 0 when using all_veg
633be0e 
I'm hopeful that this will address ESCOMP#203
@billsacks billsacks mentioned this issue May 21, 2020
Merged
ekluzek added a commit to jtruesdal/ctsm that referenced this issue May 27, 2020
@ekluzek
Merge tag 'ctsm1.0.dev097' into fv3port
6c521ba 
Add two bioenergy crops (switchgrass and miscanthus)

Main change is from Yanyan Cheng: adding parameters and code for two
bioenergy crops, switchgrass and miscanthus. Along with this, there is a
new potential flux from crop leaves and stems to the crop product pool
at harvest, representing biofuel products; a new pft-specific parameter
controls this flux (biofuel_harvfrac). Currently, the out-of-the-box
surface datasets do not specify any area for these crops, but the new
parameter file will allow them to be present if specified on the surface
dataset or landuse_timeseries file. Note that this is only an option for
CLM5.0, NOT for CLM4.5. (See ESCOMP#884 for
details.)

Also, some minor fixes from Bill Sacks:
- Resolves ESCOMP#203 - Fixes creation of harvest-related variables
  on surface datasets created with the all_veg option - smallville,
  PTCLM, etc. (documented in ESCOMP#1019)
- Resolves ESCOMP#930 - Makes gindex_ocn intent(inout) rather than
  intent(out)
- Resolves ESCOMP#1021 - Changes SSP test to only do symlink if
  needed
ekluzek added a commit to ekluzek/CTSM that referenced this issue Jun 10, 2020
@ekluzek
Merge tag 'ctsm1.0.dev097' into simb4b
be3e551 
Add two bioenergy crops (switchgrass and miscanthus)

Main change is from Yanyan Cheng: adding parameters and code for two
bioenergy crops, switchgrass and miscanthus. Along with this, there is a
new potential flux from crop leaves and stems to the crop product pool
at harvest, representing biofuel products; a new pft-specific parameter
controls this flux (biofuel_harvfrac). Currently, the out-of-the-box
surface datasets do not specify any area for these crops, but the new
parameter file will allow them to be present if specified on the surface
dataset or landuse_timeseries file. Note that this is only an option for
CLM5.0, NOT for CLM4.5. (See ESCOMP#884 for
details.)

Also, some minor fixes from Bill Sacks:
- Resolves ESCOMP#203 - Fixes creation of harvest-related variables
  on surface datasets created with the all_veg option - smallville,
  PTCLM, etc. (documented in ESCOMP#1019)
- Resolves ESCOMP#930 - Makes gindex_ocn intent(inout) rather than
  intent(out)
- Resolves ESCOMP#1021 - Changes SSP test to only do symlink if
  needed
@billsacks billsacks removed the closed: duplicate Issue already reported, or changes included in a different PR label Aug 21, 2020
ekluzek added a commit to juliusvira/ctsm that referenced this issue Aug 22, 2022
@ekluzek
Merge tag 'ctsm1.0.dev097' into fan-2019-ctsm
1646e04 
Add two bioenergy crops (switchgrass and miscanthus)

Main change is from Yanyan Cheng: adding parameters and code for two
bioenergy crops, switchgrass and miscanthus. Along with this, there is a
new potential flux from crop leaves and stems to the crop product pool
at harvest, representing biofuel products; a new pft-specific parameter
controls this flux (biofuel_harvfrac). Currently, the out-of-the-box
surface datasets do not specify any area for these crops, but the new
parameter file will allow them to be present if specified on the surface
dataset or landuse_timeseries file. Note that this is only an option for
CLM5.0, NOT for CLM4.5. (See ESCOMP#884 for
details.)

Also, some minor fixes from Bill Sacks:
- Resolves ESCOMP#203 - Fixes creation of harvest-related variables
  on surface datasets created with the all_veg option - smallville,
  PTCLM, etc. (documented in ESCOMP#1019)
- Resolves ESCOMP#930 - Makes gindex_ocn intent(inout) rather than
  intent(out)
- Resolves ESCOMP#1021 - Changes SSP test to only do symlink if
  needed

 Conflicts:
	Externals.cfg
	bld/namelist_files/namelist_defaults_ctsm.xml
	bld/namelist_files/namelist_definition_ctsm.xml
	bld/unit_testers/build-namelist_test.pl
	src/biogeochem/CNBalanceCheckMod.F90
	src/biogeochem/CNDriverMod.F90
	src/biogeochem/CNVegetationFacade.F90
	src/main/clm_driver.F90
	src/main/clm_initializeMod.F90
	src/main/controlMod.F90
samsrabin pushed a commit to samsrabin/CTSM that referenced this issue May 3, 2024
@jedwards4b
Merge pull request ESCOMP#203 from jedwards4b/no_gfortan_warnings
cb7d09e 
remove shr_mpi_mod
Description of changes

Remove shr_mpi_mod and replace with ESMF_VM operations.
Specific notes

Contributors other than yourself, if any:

CDEPS Issues Fixed: ESCOMP#38

Are there dependencies on other component PRs (if so list):

Are changes expected to change answers: bfb
Any User Interface Changes (namelist or namelist defaults changes): no

Testing performed (e.g. aux_cdeps, CESM prealpha, etc): aux_cdeps on cheyenne intel, all pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug something is working incorrectly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@billsacks