-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIMICS todo list #2361
Comments
Tagging @elisacw, so she is up-to-date. |
Thanks @mvdebolskiy |
@slevis-lmwg I'm trying to understand why CHEM pools are so much smaller than AVAIL in the plot above. One thing I can't track down is the fraction of litter inputs that bypasses the microbial "filter" and goes direct to SOM pools. This parameter was called |
I'm adding @wwieder's notes from an email here: in CNCStateUpdate1Mod.F90, line 214
As a separate issue, it seems like allocation to litter pools is actually being determined in CNPhenologyMod.F90 by the parameters lf_f & lf_r. This is different to how MIMICS handles the allocation to LIT1 and LIT2 pools, but may not be worth addressing at this point. |
@wwieder and I agreed on the following steps:
|
Here is my first draft of the code change in CNCStateUpdate1Mod.F90:
...and equivalent in CNNStateUpdate1Mod.F90:
|
looks good to me Sam. Once you have this ready to go I'll test it out on my branch. Easiest may be for me to use use source mods, so if you can point me to your branch / directory I'll grab the StateUpdate1Mod files to test things out. Alternatively, I guess you can push to my PR branch and I can pull the changes onto my local branch? |
@slevis-lmwg is this something that can be accomplished in Sprint 3, even if it's just implementing the code mods on a branch tag that I can merge into simulations I'm running with MIMICS? It will remove a blocker for me, but isn't super urgent as I'm on PTO next week :) |
@wwieder I will add to my Sprint 3 TODOs. |
Working with @piersond and @katierocci on our MSBio project we've realized a few things should be altered in MIMICS. This is a running list of issues to address. Checked boxes have been evaluated in single point testing
Both of the isssues above are related to this line, which is repeated for oli_mic too:
The text was updated successfully, but these errors were encountered: