Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIMICS updates, WIP #2365

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

MIMICS updates, WIP #2365

wants to merge 9 commits into from

Conversation

wwieder
Copy link
Contributor

@wwieder wwieder commented Feb 14, 2024

Description of changes

code and parameter changes to address #2361

Specific notes

removes NPP control on turnover
fixes density dependent control on turnover
adds litterfall fluxes that bypass litter pools, directly contributing to SOM

Contributors other than yourself, if any:
@slevis-lmwg

CTSM Issues Fixed (include github issue #):
#2361

Are answers expected to change (and if so in what way)?
Soil C stocks will change with these code and parameter updates

Any User Interface Changes (namelist or namelist defaults changes)?
/glade/u/home/wwieder/scratch/mimics_NEON/modified parameter file available ctsm51_params.c240207b_v1.3_t1.5_b1.5.nc

Testing performed, if any:
scientific testing in single point cases is ongoing

@wwieder wwieder removed the request for review from slevis-lmwg February 14, 2024 23:30
@wwieder wwieder marked this pull request as draft February 14, 2024 23:30
wwieder
wwieder commented Feb 14, 2024
View reviewed changes
cime_config/usermods_dirs/NEON/defaults/shell_commands
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to user_mods don't need to be included in this PR.

@wwieder
Copy link
Contributor Author

wwieder commented Feb 14, 2024

@slevis-lmwg the parameter files listed above has mimics_fi added to it. Let me know if this looks OK to you.
Note, this also makes changes to several other MIMICS parameters (mimics_vint, mimics_densdep, & mimics_tau_mod)

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Mar 16, 2024 •
edited

I checked out this branch, added the code that we discussed, and pointed to the above params file. The model builds and runs.

I tried to push back to the branch, but I do not have permissions.

The files to copy to your /SourceMods are:

/glade/work/slevis/git/vert_res_in_mimics/src/biogeochem/CNCStateUpdate1Mod.F90
/glade/work/slevis/git/vert_res_in_mimics/src/biogeochem/CNNStateUpdate1Mod.F90
/glade/work/slevis/git/vert_res_in_mimics/src/main/clm_varpar.F90
/glade/work/slevis/git/vert_res_in_mimics/src/main/pftconMod.F90
/glade/work/slevis/git/vert_res_in_mimics/src/soilbiogeochem/SoilBiogeochemDecompCascadeMIMICSMod.F90

@wwieder
Copy link
Contributor Author

wwieder commented Mar 16, 2024

Thanks, Sam. Can you point me to the directory where your files are?

@slevis-lmwg
Copy link
Contributor

Sorry for the omission! I updated the post with the full file paths now.

@wwieder
Copy link
Contributor Author

wwieder commented Mar 18, 2024

That was a quick Friday afternoon! Thanks.

You can teach me how to grant permissions at some point, but I'll kick off a few runs with these code modifications and see how they look next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsrabin samsrabin Awaiting requested review from samsrabin

At least 1 approving review is required to merge this pull request.

Assignees

@slevis-lmwg slevis-lmwg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wwieder @slevis-lmwg