Add a system test: turning on water isotopes shouldn't change answers #571
Comments
|
See also #686 - similar test for C isotopes. With the new cprnc, for this to pass, we'd need a namelist flag that turns off the water isotope diagnostic fields so that there are no differences in field lists. |
billsacks
added a commit
that referenced
this issue
Aug 6, 2019
Modularize snow cover fraction method This tag moves the calculation of frac_sno - and the related updates of snow_depth - into a new set of classes, with one class for each parameterization (Niu & Yang 2007 and Swenson & Lawrence 2012). Previously, the code always calculated frac_sno the new way, but then possibly overwrote it if using the older Niu & Yang method. The new code cleans this up, only doing the calculations that are needed for each method. In addition, other code that is specific to one of the two methods is now moved to a home that makes this dependence on method explicit. This includes the addition of newsnow to int_snow: previously, int_snow was always updated using an equation specific to the newer CLM5 parameterization of frac_sno, which was not appropriate if using the Niu & Yang parameterization; this doesn't make a difference currently, since int_snow is only referenced if using the Swenson & Lawrence parameterization, but this clears up some confusion. Also, time-constant parameters read from namelist or the netCDF parameter file now reside in the appropriate class rather than being more global. This tag also renames two namelist options to increase clarity: - subgridflag is renamed to use_subgrid_fluxes, and is now a logical - oldfflag is renamed to snow_cover_fraction_method, and is now a string Resolves #502 Resolves #503 Resolves #571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Turning on water isotopes shouldn't change answers for bulk water or any other non-water-isotope quantity. We should add a new system test to confirm this (similar in concept to the LVG test).
The text was updated successfully, but these errors were encountered: