Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to specify soil layer structure more flexibly #728

Closed
billsacks opened this issue May 22, 2019 · 0 comments · Fixed by #759
Closed

Allow users to specify soil layer structure more flexibly #728

billsacks opened this issue May 22, 2019 · 0 comments · Fixed by #759
Assignees
@slevis-lmwg
Labels
type: enhancement new capability or improved behavior of existing capability

Comments

@billsacks
Copy link
Member

billsacks commented May 22, 2019 •
edited
Loading

Rather than (or maybe in addition to?) having a fixed, predefined set of possible soil layer structures, we'd like to let the user specify the soil layer structure arbitrarily via a namelist setting. The user would probably specify a vector of layer thicknesses, though the details of the "user interface" still need to be worked out.

This has been raised as a high priority need by @barlage and Stan Benjamin.

See also #279 , #729
@billsacks billsacks added the type: enhancement new capability or improved behavior of existing capability label May 22, 2019
This was referenced May 22, 2019
Closed
Closed
@slevis-lmwg slevis-lmwg mentioned this issue Jul 6, 2019
Merged
billsacks added a commit that referenced this issue Aug 1, 2019
@billsacks
Merge branch 'soil_layer_def_cleanup'
00769d5 
Soil layer definition clean-up and user-defined option

Code clean-up clarifes that there are two types of soil layer
definition: the node-based and the thickness-based.

User-defined option allows user to specify a soil layer profile in the
form of a dzsoi vector (values in meters) in the thickness-based
approach.

Default nlevsoi for NWP configurations had to change from 5 to 4 for
consistency with the new error check described in known bugs below.

Other code clean-up removes a couple of sections of repeating code.

Resolves #279
Resolves #728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slevis-lmwg slevis-lmwg

Labels
type: enhancement new capability or improved behavior of existing capability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Soil layer definition clean-up and user-defined option slevis-lmwg/ctsm
2 participants
@billsacks @slevis-lmwg