Some bounds assertions aren't done when threading is on

[billsacks]

In these two blocks of code:

CTSM/src/biogeochem/CNPrecisionControlMod.F90

Lines 438 to 447 in 1720bc7

	#ifndef _OPENMP
	if ( present(c13) .and. use_c13 )then
	SHR_ASSERT_ALL((lbound(c13) == (/bounds%begp/)), 'lbnd(c13)'//errMsg(sourcefile, lineno))
	SHR_ASSERT_ALL((ubound(c13) == (/bounds%endp/)), 'ubnd(c13)'//errMsg(sourcefile, lineno))
	end if
	if ( present(c14) .and. use_c14 )then
	SHR_ASSERT_ALL((lbound(c14) == (/bounds%begp/)), 'lbnd(c14)'//errMsg(sourcefile, lineno))
	SHR_ASSERT_ALL((ubound(c14) == (/bounds%endp/)), 'ubnd(c14)'//errMsg(sourcefile, lineno))
	end if
	#endif

CTSM/src/biogeochem/CNPrecisionControlMod.F90

Lines 525 to 534 in 1720bc7

	#ifndef _OPENMP
	if ( present(c13) .and. use_c13 )then
	SHR_ASSERT_ALL((lbound(c13) == (/bounds%begp/)), errMsg(sourcefile, __LINE__))
	SHR_ASSERT_ALL((ubound(c13) == (/bounds%endp/)), errMsg(sourcefile, __LINE__))
	end if
	if ( present(c14) .and. use_c14 )then
	SHR_ASSERT_ALL((lbound(c14) == (/bounds%begp/)), errMsg(sourcefile, __LINE__))
	SHR_ASSERT_ALL((ubound(c14) == (/bounds%endp/)), errMsg(sourcefile, __LINE__))
	end if
	#endif

the bounds of subroutine arguments are not being checked if threading is on. It looks like this came in in clm4_5_9_r184. Presumably that was needed at some point, but I hope we can remove this now: if this is needed, I think that would suggest a threading bug.

@ekluzek I'm assigning this to you since you made clm4_5_9_r184, but it probably isn't high priority. The fix should be simple (removing the #ifdefs) as long as it doesn't cause problems.

[ekluzek]

Yes, it looks like to me that I should be able to remove the OMP idef's and it should work correctly. So we'll have to try it and make sure it does.

[negin513]

Removing the #ifndef _OPENMPgive us error in lbound and ubound assertions for some of the threading tests. After a discussion with @billsacks today, we decided to remove the pointer attribute of c13 and c14. In all Truncate**** functions (e.g. TruncateCandNStates, TruncateNStates, etc.) , all arrays should have lbound and ubound in the slices – this includes the existing ones that have just lower bound in addition to c13 and c14 which currently don't have any bounds. We also have to remove lbound assertions for c13 and c14. These changes seem to resolve the errors of threading tests.

[billsacks]

Fixed by @negin513 in ctsm1.0.dev084