Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to mksurfdata.pl to handle "negative" years (ie. BCE) #934

Closed
ekluzek opened this issue Feb 24, 2020 · 3 comments
Closed

Add option to mksurfdata.pl to handle "negative" years (ie. BCE) #934

ekluzek opened this issue Feb 24, 2020 · 3 comments
Assignees
Labels
closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix tag: enh - new science enhancement that brings in new science capabilities type: enhancement new capability or improved behavior of existing capability
Milestone

Comments

@ekluzek
Copy link
Contributor

ekluzek commented Feb 24, 2020

The Holocene simulations will start at 10,000 BCE and run through 850 AD. In order to handle this for the surface datasets we need to have a way to handle "negative" years. We are going to label this with positive years that start at 10,000 BCE and then run through year 10,0000 which will be 1 AD (also note that year 0 is skipped).

There will be a branch of this for the Holocene, but we might as well bring this addition to the mainline development as well.

@lawrencepj1

@ekluzek ekluzek added type: enhancement new capability or improved behavior of existing capability priority: high High priority task to fix soon, e.g., because it is a problem in important configurations branch tag: release Changes go on release branch as well as master tag: enh - new science enhancement that brings in new science capabilities tag: next this issue should get some attention in the next week or two labels Feb 24, 2020
@ekluzek ekluzek added this to the cesm2.1.3 milestone Feb 24, 2020
@ekluzek ekluzek self-assigned this Feb 24, 2020
@billsacks billsacks removed the tag: next this issue should get some attention in the next week or two label Feb 27, 2020
@billsacks billsacks added this to Needs triage in High priority via automation Feb 27, 2020
@billsacks billsacks moved this from Needs triage to To do in High priority Feb 27, 2020
@ekluzek ekluzek modified the milestones: cesm2.1.3, cesm2.1.4 Mar 26, 2020
@ekluzek
Copy link
Contributor Author

ekluzek commented Nov 5, 2020

OK, I'm working on this with @lawrencepj1. They are ready to start this simulation. We need the years to match the file CAM is using:

$CSMDATA/atm/waccm/lb/LBC_8501BP-2CE_TransientHolocene_0p5degLat_GlobAnnAvg_c20201029.nc

That file has year 0 as 6551 BCE and year 6552 as 2 CE.

So we need our file to run from year index 501 to 6552. The year index 501 corresponds to year 6050 BCE and 6552 is 2 CE.

    0 = 6551 BCE
    1  = 6550 BCE
   10 = 6541 BCE
500 = 6051 BCE
501 = 6050 BCE

6550 = 1 BCE
6551 = 1 CE
6552 = 2 CE

@lawrencepj1
Copy link

lawrencepj1 commented Nov 5, 2020 via email

@billsacks billsacks removed the priority: high High priority task to fix soon, e.g., because it is a problem in important configurations label Jul 15, 2021
@billsacks billsacks removed this from To do in High priority Jul 15, 2021
@ekluzek ekluzek added closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix and removed branch tag: release Changes go on release branch as well as master labels Feb 2, 2022
@ekluzek
Copy link
Contributor Author

ekluzek commented Feb 2, 2022

We worked around this for the work that needed it. I'm going to close this as a WONTFIX, unless we run into this need again. The application is specialized enough that it's not a standard thing that will be done.

@ekluzek ekluzek closed this as completed Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix tag: enh - new science enhancement that brings in new science capabilities type: enhancement new capability or improved behavior of existing capability
Projects
None yet
Development

No branches or pull requests

3 participants