Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History fields table missing from CLM5 Users Guide #941

Closed
katiedagon opened this issue Mar 12, 2020 · 8 comments · Fixed by #1222
Closed

History fields table missing from CLM5 Users Guide #941

katiedagon opened this issue Mar 12, 2020 · 8 comments · Fixed by #1222
Assignees
Labels
type: documentation additions or edits to user-facing documentation

Comments

@katiedagon
Copy link

The table of history fields is missing from the current users guide (section 1.2.3.1.3, Table 1.3)
https://escomp.github.io/ctsm-docs/doc/build/html/users_guide/setting-up-and-running-a-case/customizing-the-clm-namelist.html#table-1-3-clm-history-fields

Several of the links on that page are also broken (e.g., section 1.2.3.1 and section 1.2.3.1.1)

@katiedagon katiedagon added the type: documentation additions or edits to user-facing documentation label Mar 12, 2020
@ekluzek ekluzek self-assigned this Mar 12, 2020
@billsacks billsacks added the blocked: dependency wait to work on this issue until another issue is resolved label Nov 4, 2020
@billsacks
Copy link
Member

Blocked by #34

@billsacks
Copy link
Member

@slevisconsulting @katiedagon @danicalombardozzi @dlawrenncar @wwieder I just rebuilt the documentation with @slevisconsulting 's changes . You can find the table here: https://escomp.github.io/ctsm-docs/versions/master/html/users_guide/setting-up-and-running-a-case/master_list_file.html

@dlawrenncar
Copy link
Contributor

dlawrenncar commented Nov 21, 2020 via email

@billsacks
Copy link
Member

Yes, I was a bit confused by the need to find the scroll bar at the bottom, too. For what it's worth, it worked for me to use the right arrow key to scroll, avoiding the need to scroll to the bottom. Maybe not an ideal solution.

@slevisconsulting I'll let you reply to @dlawrenncar 's comment, too.

@danicalombardozzi
Copy link
Contributor

danicalombardozzi commented Nov 21, 2020 via email

@slevis-lmwg
Copy link
Contributor

@dlawrenncar a first attempt shows me that your request for a list of variable status (active is T or F) is very straightfwd.

@danicalombardozzi alphabetizing seems like a good idea, too. I can look into a way of doing that, unless @billsacks has a shortcut suggestion off the top of his head.

@billsacks
Copy link
Member

From a quick look for whether we have any generic sorting methods, I can't find any. But we do have an inline sort in another place in histFileMod that could be reused for this purpose: see ! Sort each list of active entries. It's an inefficient sort (O(n^2)), but for this purpose it should be okay. I think that, with just a bit of work, one could make a generic routine that operates on either history tape entries (as is currently done) or the master field list (as is needed in this new case)... but I'm also okay with reuse-via-copy-and-paste in this case, since it isn't critical that the two reuse the same method.

@billsacks
Copy link
Member

billsacks commented Nov 23, 2020

(But I'd also be happy to help with the changes needed to make this a generic routine if you'd like, if you don't see how... basically it will involve some object-orientation tricks. I'm fine either way.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation additions or edits to user-facing documentation
Projects
None yet
6 participants