Some BFB changes and Hydraulic redistribution

[negin513]

Description of changes

Resolves issue: #881, #1020, #1102 and includes Hydraulic redistribution

Specific notes

Contributors other than yourself, if any: @djk2120

CTSM Issues Fixed (include github issue #):
#1020, #881

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)?

• maxpatch_pft is removed from the namelist.
• Four additional fields added to the output:
  • QHR (patch-level hydraulic redistribution)
  • VEGWPLN (local noon vegetation water potential)
  • VEGWPPD (predawn vegetation water potential)
  • VPD_CAN: canopy vapor pressure deficit (functional input to Medlyn model)

Testing performed, if any:

• aux_clm on Cheyenne.
• aux_clm on Izumi

[ekluzek]

I have a couple questions that I ask about, and one required change. It looks like a section of soilm variables in the namelist xml files was accidentally deleted. So that should go back in. There's a test that should have failed as a result.

It sounds like there's some other tests that are failing as well, that will need to be addressed.

[ekluzek]

OK, I missed the reason the soilm fields were removed was just because they were duplicated. So I removed that request. Now, we just need to get the restart tests working. And I had a few other comments that you can decide how to handle.

[dlawrenncar]

I think these should all be active by default.

…

On Wed, Oct 14, 2020 at 4:19 PM djk2120 ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/biogeophys/PhotosynthesisMod.F90 <#1187 (comment)>: > @@ -376,6 +376,14 @@ subroutine InitHistory(this, bounds) call hist_addfld1d (fname='RH_LEAF', units='fraction', & avgflag='A', long_name='fractional humidity at leaf surface', & ptr_patch=this%rh_leaf_patch, set_spec=spval, default='inactive') + + this%vpd_can_patch(begp:endp) = spval + call hist_addfld1d (fname='VPD_CAN', units='kPa', & + avgflag='A', long_name='canopy vapor pressure deficit', & + ptr_patch=this%vpd_can_patch, set_spec=spval, default='inactive') Thanks, that's a good question. These are all variables that I am interested in, but I don't have a good feel for whether they are of broad enough interest to be on all the time. Maybe @dlawrenncar <https://github.com/dlawrenncar> has a better feel. I've added four new variables: - predawn vegetation water potential - local noon vegetation water potential - hydraulic redistribution - canopy VPD (which is the functional input to the medlyn model) Which, if any should be default active? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1187 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFABYVGFCDZ4J5QQXXJ63KDSKYPYRANCNFSM4SRBTEHA> .

[ekluzek]

@negin513 is testing this with her PR. There are a few changes she'll make there for this PR. @djk2120 is also going to make some future changes that will resolve some other questions I had.

[ekluzek]

So the only thing to do is to get the restart tests passing, by adding the two fields to restart files. And then add the new fields to be active by default.

[dlawrenncar]

I think that Bill and Erik were saying that these variables needed to be added to the restart file to resolve the issue restart problem. Making them active by default won't solve it.

…

On Thu, Oct 15, 2020 at 1:24 PM Negin Sobhani ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/biogeophys/CanopyStateType.F90 <#1187 (comment)>: > @@ -243,6 +246,14 @@ subroutine InitHistory(this, bounds) call hist_addfld2d (fname='VEGWP', units='mm', type2d='nvegwcs', & avgflag='A', long_name='vegetation water matric potential for sun/sha canopy,xyl,root segments', & ptr_patch=this%vegwp_patch) + this%vegwp_ln_patch(begp:endp,:) = spval + call hist_addfld2d (fname='VEGWPLN', units='mm', type2d='nvegwcs', & making these defaults active did not resolve the issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1187 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFABYVGWKAYKRZZG7UZKYSLSK5D7DANCNFSM4SRBTEHA> .

[ekluzek]

@dlawrenncar yep we just went over that with @negin513, and showed her how to add to the restart file. So she is working on that. That should resolve the fails.

[negin513]

@djk2120 and @ekluzek : Can you please confirm the name of the second dimensions of VEGWPLN and VEGWPPD?

CTSM/src/biogeophys/CanopyStateType.F90

Lines 547 to 557 in 591727f

	call restartvar(ncid=ncid, flag=flag, varname='VEGWPLN', xtype=ncd_double, &
	dim1name='pft', dim2name='vegwcs', &
	long_name='vegetation water matric potential for sun/sha canopy,xyl,root at local noon', units='mm', &
	interpinic_flag='skip', readvar=readvar, data=this%vegwp_ln_patch)
	call restartvar(ncid=ncid, flag=flag, varname='VEGWPPD', xtype=ncd_double, &
	dim1name='pft', dim2name='vegwcs', &
	long_name='predawn vegetation water matric potential for sun/sha canopy,xyl,root', units='mm', &
	interpinic_flag='skip', readvar=readvar, data=this%vegwp_pd_patch)

At first, I had this as nvegwcs which caused all tests to fail and when I changed it to vegwcs some tests are passing and some are failing during the run phase.

If the second dimension is nvegwcs, should I define another dimension to restart files called nvegwcs? Please look here for the current dimension definitions:

CTSM/src/main/restFileMod.F90

Lines 533 to 551 in 591727f

	call ncd_defdim(ncid , nameg , numg , dimid)
	call ncd_defdim(ncid , namel , numl , dimid)
	call ncd_defdim(ncid , namec , numc , dimid)
	call ncd_defdim(ncid , namep , nump , dimid)
	call ncd_defdim(ncid , nameCohort , numCohort , dimid)
	call ncd_defdim(ncid , 'levgrnd' , nlevgrnd , dimid)
	call ncd_defdim(ncid , 'levlak' , nlevlak , dimid)
	call ncd_defdim(ncid , 'levsno' , nlevsno , dimid)
	call ncd_defdim(ncid , 'levsno1' , nlevsno+1 , dimid)
	call ncd_defdim(ncid , 'levtot' , nlevsno+nlevgrnd, dimid)
	call ncd_defdim(ncid , 'numrad' , numrad , dimid)
	call ncd_defdim(ncid , 'levcan' , nlevcan , dimid)
	if ( use_hydrstress ) then
	call ncd_defdim(ncid , 'vegwcs' , nvegwcs , dimid)
	end if
	call ncd_defdim(ncid , 'glc_nec', maxpatch_glcmec, dimid)
	call ncd_defdim(ncid , 'glc_nec1', maxpatch_glcmec+1, dimid)

[djk2120]

Hi Negin, 'vegwcs' is the correct dimension name

…

On Mon, Oct 19, 2020 at 3:19 PM Negin Sobhani ***@***.***> wrote: @djk2120 <https://github.com/djk2120> and @ekluzek <https://github.com/ekluzek> : Can you please confirm the name of the second dimensions of VEGWPLN and VEGWPPD? https://github.com/ESCOMP/CTSM/blob/591727fcf1eef7c0587154f833ea95219d6aecf4/src/biogeophys/CanopyStateType.F90#L547-L557 At first, I had this as nvegwcs which caused all tests to fail and when I changed it to vegwcs some tests are passing and some are failing during the run phase. If the second dimension is nvegwcs, should I define another dimension to restart files called nvegwcs? Please look here for the current dimension definitions: https://github.com/ESCOMP/CTSM/blob/591727fcf1eef7c0587154f833ea95219d6aecf4/src/main/restFileMod.F90#L533-L551 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1187 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADNHR5SRIA55QNBUXNR2Z4DSLSUNZANCNFSM4SRBTEHA> .