Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Assign to project" action (?) #2342

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix "Assign to project" action (?) #2342

merged 2 commits into from
Feb 1, 2024

Conversation

samsrabin
Copy link
Contributor

Description of changes

Removes backticks from the YAML file that were causing syntax errors

Specific notes

Contributors other than yourself, if any: @mvdebolskiy, @ekluzek

CTSM Issues Fixed (include github issue #): None

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any: None

@samsrabin samsrabin added the tag: simple bfb easy to fix, bit-for-bit label Jan 31, 2024
@samsrabin samsrabin self-assigned this Jan 31, 2024
@samsrabin samsrabin added priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations and removed priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations labels Jan 31, 2024
@samsrabin samsrabin added this to In progress - master in Upcoming tags Jan 31, 2024
@samsrabin samsrabin added the PR status: ready PR: author feels this is ready to merge in label Jan 31, 2024
Copy link
Contributor

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to remove the : after priority: on line 16.

We should just approve this and send it to master without worrying about a tag.

@wwieder
Copy link
Contributor

wwieder commented Feb 1, 2024

seems good, Erik. I don't think this needs a tag.

@samsrabin samsrabin merged commit e611238 into master Feb 1, 2024
3 checks passed
Upcoming tags automation moved this from In progress - master to Master Tags/Issues Done Feb 1, 2024
@mvdebolskiy
Copy link
Contributor

Can you rerun [Merge tag 'ctsm5.1.dev166' into CESM3_dev](https://github.com/ESCOMP/CTSM/actions/runs/7750813536) action to see if it doesn't fail?

@samsrabin
Copy link
Contributor Author

Hmm. Not sure how I would do that.

@mvdebolskiy
Copy link
Contributor

Oh, you can't apparently. https://docs.github.com/en/actions/managing-workflow-runs/re-running-workflows-and-jobs

@ekluzek ekluzek deleted the fix-auto-assign branch February 12, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR status: ready PR: author feels this is ready to merge in tag: simple bfb easy to fix, bit-for-bit
Projects
Upcoming tags
Done (non release/external)
Development

Successfully merging this pull request may close these issues.

None yet

5 participants