Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove manage_externals, use git submodule #28

Closed
wants to merge 2 commits into from

Conversation

jedwards4b
Copy link
Collaborator

Remove manage externals, use git submodules.

@jedwards4b jedwards4b marked this pull request as draft December 29, 2023 17:25
@jimmielin
Copy link
Collaborator

Thanks @jedwards4b! Does manage_externals automatically checkout git submodules as well? This will be of interest to GEOS-Chem within CESM as well, as we include the GEOS-Chem source code as an external as well I think.

@gold2718
Copy link
Collaborator

Thanks @jedwards4b! Does manage_externals automatically checkout git submodules as well? This will be of interest to GEOS-Chem within CESM as well, as we include the GEOS-Chem source code as an external as well I think.

By default, manage_externals will checkout submodules in an external after it updates it. This behavior can be prevented or selectively overridden with a local Externals file. See the documentation (./manage_externals/checkout_externals --help).

@jedwards4b jedwards4b marked this pull request as ready for review May 29, 2024 19:17
Copy link
Collaborator

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but we need to update the externals version, then I will pull into development for release.

Is this compatible with latest cam_development now? Or a more updated version of manage_externals is required to use this functionality?

@jedwards4b jedwards4b marked this pull request as draft June 12, 2024 12:27
@jedwards4b
Copy link
Collaborator Author

The cesm3.0 release will not use manage externals and will instead use a tool called git-fleximod. We have created a branch tag in this repository updating the hemco version currently used by CAM to work with git-fleximod. When we are ready to update hemco in cam to a newer version this PR or that branch will need to be merged.

@jimmielin
Copy link
Collaborator

The cesm3.0 release will not use manage externals and will instead use a tool called git-fleximod. We have created a branch tag in this repository updating the hemco version currently used by CAM to work with git-fleximod. When we are ready to update hemco in cam to a newer version this PR or that branch will need to be merged.

Sounds good, thank you. I will hold off merging this PR, until it is anticipated that the latest HEMCO_CESM tag will be used in CESM3.0. In the interim we may still have to merge releases from this repository into cam_development for use in CESM2.x, particularly with GEOS-Chem.

@jedwards4b
Copy link
Collaborator Author

The final cesm2.3 tag is beta17 - the next tag will be cesm3.0beta01.

@jimmielin
Copy link
Collaborator

Thanks @jedwards4b! I will wait until cesm3.0beta01 is tagged (which will use git-fleximod?) so I can test the latest version of this interface with latest HEMCO available, and then merge in this PR and make a PR against ESCOMP/CAM to update everything (either for CESM3.0 or for a future release). In the meantime, the branch you created can be used for CESM3.0 Beta01.

@jimmielin jimmielin added the enhancement New feature or request label Jul 30, 2024
@jimmielin
Copy link
Collaborator

The changes in this PR have been incorporated in HEMCO-CESM 1.4.0, we have tested and migrated to using git submodules in #38. I'm closing this for now. A PR to ESCOMP/CAM with our latest tag supporting git submodules will arrive shortly.

@jimmielin jimmielin closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants