Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sites to use their own keystore alias and password #32

Closed
LucaCinquini opened this issue Apr 17, 2014 · 5 comments
Closed

Allow sites to use their own keystore alias and password #32

LucaCinquini opened this issue Apr 17, 2014 · 5 comments
Assignees
Milestone

Comments

@LucaCinquini
Copy link
Member

Currently the installer overrides the Tomcat server.xml with a default Tomcat alias of "my_esgf_node". It would be good to allow sites to specify their own value for the keystore "alias" and "password" in the esgf.properties file, and have the installer use those values.

@LucaCinquini LucaCinquini added this to the ESGF 1.7.1 milestone Apr 17, 2014
@LucaCinquini
Copy link
Member Author

Hi Nicolas,
maybe a better requirement would be for the installer to not override server.xml, so that if that file has been specially configured (for a variety of possible reasons), the installer does not throw those settings away.

@ncarenton ncarenton modified the milestones: ESGF 1.8.0, ESGF 1.7.1 Sep 4, 2014
@ncarenton
Copy link

Hi Luca,

The installer actually uses this template when tomcat is being installed or upgraded:
http://distrib-coffee.ipsl.jussieu.fr/pub/esgf/dist/devel/externals/bootstrap/node.server.xml-v7

We could maybe add a keystorealias entry in esgf.properties if you like...

@LucaCinquini
Copy link
Member Author

Hi Nicolas,
I think it’s a good idea…
thanks, L

On Nov 5, 2014, at 8:33 AM, Nicolas Carenton <notifications@github.commailto:notifications@github.com> wrote:

Hi Luca,

The installer actually uses this template when tomcat is being installed or upgraded:
http://distrib-coffee.ipsl.jussieu.fr/pub/esgf/dist/devel/externals/bootstrap/node.server.xml-v7

We could maybe add a keystorealias entry in esgf.properties if you like...


Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-61825191.

@ncarenton
Copy link

OK so you will need to manually add this prop to your node config and I'll make the installer read it. But let's not ask the node admin for keystorealias value during the interactive part of the installation. Do you agree?

@ncarenton ncarenton self-assigned this Nov 7, 2014
@LucaCinquini
Copy link
Member Author

Hi Nicolas,
yes good plan. I love having hidden and undocumented features :)…
thanks, Luca

On Nov 7, 2014, at 3:05 AM, Nicolas Carenton <notifications@github.commailto:notifications@github.com> wrote:

OK so you will need to manually add this prop to your node config and I'll make the installer read it. But let's not ask the node admin for keystorealias value during the interactive part of the installation. Do you agree?


Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-62122058.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants