Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use consistent delete command in "esgprep drs todo" #14

Closed
alaniwi opened this issue Dec 22, 2017 · 1 comment
Closed

use consistent delete command in "esgprep drs todo" #14

alaniwi opened this issue Dec 22, 2017 · 1 comment

Comments

@alaniwi
Copy link
Collaborator

alaniwi commented Dec 22, 2017

esgprep drs todo uses sometimes rm -f and sometimes unlink to remove files. (One is used for duplicate files, and the other is used for the "latest" symlink when replacing it.) You might want to be consistent.

(The calling code I am writing will accept either.)
@glevava
Copy link
Member

glevava commented Dec 23, 2017

Actually I didn't think there is no major difference between both regarding symlink removal.
I'll change this for "rm -f" homogeneously for duplicated files from the incoming and the "latest" symlink removal as well.
Thanks

@glevava glevava closed this as completed Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alaniwi @glevava