-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to requests for search connection #14
Conversation
…rte/esgf-pyclient into enhancement/requests_conn
Hi @laliberte, |
Hi @agstephens, We could go the At the moment, my PRs are either clean-ups or under-the-hood changes that are 100% backward-compatible (except maybe for raised exceptions). Because these are mostly for stability with the ever-evolving python ecosystem, I would recommend merging into There are two things with the current PR and #13:
|
This PR builds upon #13.
It introduces three components to the search connection:
The query is now sent using
requests
which greatly simplifies python 3 compatiblity.The search connection can now be instantiated and the requests session kept alive.
The
requests_cache
package is internally supported and provides an easy way to enable simple caching of queries.One advantage of using
requests
is the proper handling of timeouts and verified / unverified queries.