added username to logon_with_openid to script CEDA access more easily #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cojacoo , the change looks fine but I would rather we had an extra unit test or two to support it. Could you add the test(s) and include them in the Pull Request? Many thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you so much for this package. I ran quite sometimes into a minor issue with the logon function when CEDA actually required a username but self._get_logon_details(openid) would not provide them.
I suggest a very small change to allow for explicit username provision to the logon_with_openid function. If left empty, everything will work as before. If provided, the username is propagated to the logon function. This fix solves the issue for me.
All the best.
Conrad