Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding USGS Lithology term definitions #290

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

brandonnodnarb
Copy link
Member

Adding scope notes from USGS Lithology terms.

This is meant a test to discuss tags/annotation axioms.

Initial discussion points for the next SWEET working session:

  1. dcterms:source links versus text
  2. dcterms:creator vs dcterms:contributor vs other vs nothing
  3. multiple dcterms:source tags versus dcterms:source and a skos:exactMatch tag

this file should be added to .gitignore (removed from tracking)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is with the extra space on the front of many of the subClassOf and label statements?

@cmungall
Copy link
Collaborator

cmungall commented Jan 18, 2024 via email

@brandonnodnarb
Copy link
Member Author

Thanks, @cmungall. This, and the rest of the definitions, will have been created using ROBOT templates. I suspect it's OWLAPI version mismatch issue. I am going through the ODK tutorials, but thanks for the tip.

@brandonnodnarb
Copy link
Member Author

brandonnodnarb commented Jan 18, 2024

Per our SWEET Ontology Working Session yesterday, we discussed the following:

  1. change skos:scopeNote to skos:definition irrespective of how the annotation is presented in the source vocab
  2. dcterms:creator should be changed to something more appropriate for this task
    • prov:wasGeneratedBy could work; need to ensure object of statement is an agent instead of an action
    • dcterms:contributor could work
  3. need a tag for reviewers of term relationships where appropriate
    • pro:reviewer from the 'Publishing Roles Ontology' (SPAR) seems intuitive; does it need further role setup?
    • dcterms:contributor could work if not used in 2 and assuming appropriate notes in documentation/wiki are added
  4. where a link to a resource is available, useskos:exactMatch for the link as well as dcterms:source for the natural language text---e.g. "USGS Lithologic terms"
  5. instead of embedding annotation axioms in source ontology module/turtle file, generate a separate ttl file for each vocabulary; similar to rdfs:comments from previous versions

@brandonnodnarb
Copy link
Member Author

As per the notes, this PR is now stale. @brandonnodnarb will issue a new PR which reflects discussed changes.

@brandonnodnarb
Copy link
Member Author

per Convo at today's meeting, suggest for
2. use dcterms:contributor
3. use CReDIT:validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants