Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-81 Alignment with DCAT #97

Merged
merged 2 commits into from Oct 1, 2018
Merged

ISSUE-81 Alignment with DCAT #97

merged 2 commits into from Oct 1, 2018

Conversation

lewismc
Copy link
Member

@lewismc lewismc commented Sep 29, 2018

This issue is a step towards addressing #81
There are a few commented entries which we could either

  1. further investigate,
  2. retain as is e.g. as comments, or
  3. remove and accept the alignment as proposed in this PR

Thanks @dr-shorthair for the prerequisite review.

Copy link
Collaborator

@dr-shorthair dr-shorthair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines 146-148 appear to repeat 143-145.
Otherwise I think this is good.

There are some implied alignments between DCAT and PROV arising which I think are consistent with https://github.com/w3c/dxwg/blob/dcat-issue79-simon/dcat/rdf/dcat-prov.ttl

@lewismc lewismc merged commit b826a11 into ESIPFed:master Oct 1, 2018
@lewismc lewismc deleted the ISSUE-81 branch October 1, 2018 17:26
@lewismc
Copy link
Member Author

lewismc commented Oct 1, 2018

Thank you for review and comments @dr-shorthair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants