Remove references to CISM1-only grid for CESM #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CESM-CISM no longer supports CISM1, so we can remove support for its 5-km grid.
billsacks
added
ty: enhancement
Responsibility: CESM
|
@fischer-ncar you should wait to merge this until you're ready to bring cism2_1_74 and ESCOMP/CESM#179 into CESM testing - so probably after cesm2_3_beta01 is done. If you merge it before then, the old tests with CISM1 (G1 in compset names) will fail. That's not a big deal, so if you don't mind just ignoring those failures, you can bring this in sooner. |
fischer-ncar
approved these changes
Mar 11, 2021
fischer-ncar
changed the title
|
@billsacks this PR has conflicts, once you fix it I can merge it. |
Resolved Conflicts: config/cesm/config_grids.xml
|
Thanks, @fischer-ncar - I just pushed a change that resolves the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CESM-CISM no longer supports CISM1, so we can remove support for its
5-km grid.
Test suite: scripts_regression_tests on cheyenne, plus ERS_Ly11.f09_g17_gl20.T1850G.cheyenne_gnu and SMS_D_Ly1.f09_g17_gl4.T1850G.cheyenne_gnu from cism2_1_74
Test baseline: cism2_1_74 for the two extra tests
Test namelist changes: none
Test status: bit for bit
Fixes none
User interface changes?: none
Update gh-pages html (Y/N)?: N
Code review: @fischer-ncar