Update checkout_externals shebang #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
@christophergeiger3 thank you again for reporting issue #135 , and for suggesting a fix for it. However, I don't feel that your proposed fix is what we want: Since python2 has reached end of life, we don't want to require that in the shebang. I have pushed a fix that solves the underlying problem in #138 , keeping manage_externals compatible with the latest version of python3. Once again, thank you for bringing this critical issue to our attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update checkout_externals shebang to specify Python 2
User interface changes?: No
Fixes: #135