Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run a single coverage command rather than two separate commands #93

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

billsacks
Copy link
Member

I was finding that, even with the '--append' flag, some of the coverage
results were getting overwritten in the second run, resulting in a
too-low coverage report.

This turns out to have no effect on the reported coverage on master, but
it fixes the coverage report for #90: without this change, some lines
that are covered only by unit tests are listed as uncovered in the final
coverage report (at least, I think that's what was going on).

User interface changes?: No

Fixes: None

Testing:
test removed: changed 'make coverage' operation
unit tests:
system tests:
manual testing:

I was finding that, even with the '--append' flag, some of the coverage
results were getting overwritten in the second run, resulting in a
too-low coverage report.
@billsacks billsacks self-assigned this Apr 10, 2018
@coveralls
Copy link

coveralls commented Apr 10, 2018

Coverage Status

Coverage decreased (-0.3%) to 90.473% when pulling 2562830 on billsacks:work_on_coverage into 144f7d9 on ESMCI:master.

@billsacks billsacks merged commit 3b624cf into ESMCI:master Apr 10, 2018
@billsacks billsacks deleted the work_on_coverage branch April 10, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants