Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example recipe recipe_correlation.yml crashes #1477

Closed
mattiarighi opened this issue Dec 20, 2019 · 7 comments · Fixed by #1767
Closed

Example recipe recipe_correlation.yml crashes #1477

mattiarighi opened this issue Dec 20, 2019 · 7 comments · Fixed by #1767
Assignees
@bouweandela
Labels
bug diagnostic
Projects
High priority issues

Comments

@mattiarighi
Copy link
Contributor

recipe_correlation.yml crashes in the diagnostic part.
log.txt
@mattiarighi mattiarighi mentioned this issue Dec 20, 2019
Merged
@bouweandela
Copy link
Member

This is because the newly CMORized data has bounds for the pressure levels, but the running extract_levels on the model data results in data with no bounds for the pressure levels, thus the coordinates become incompatible. It worked because the old ERA-Interim data did not have bounds.

@bouweandela
Copy link
Member

Related to #1479

@valeriupredoi
Copy link
Contributor

fixed no? #1479 been closed for a while

@mattiarighi
Copy link
Contributor Author

It still crashes, just tried.

@bouweandela
Copy link
Member

The issue was moved, #1479 is now ESMValGroup/ESMValCore#414.

@bouweandela
Copy link
Member

Anyway, this is quite easy to fix, but I wonder if it's worth it, because this recipe doesn't make much sense scientifically, see also the discussion in #625.

@valeriupredoi
Copy link
Contributor

we should have a talk about a proper stats corr/Kolmogorov-Smirnoff/etc recipe at the workshop, I haven't done any stats in ages 🍺

@mattiarighi mattiarighi mentioned this issue Jul 10, 2020
Closed
@bouweandela bouweandela mentioned this issue Jul 30, 2020
Merged
5 tasks
High priority issues automation moved this from To do to Done Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bouweandela bouweandela

Labels
bug diagnostic
Projects
High priority issues
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix recipe_correlation.yml ESMValGroup/ESMValTool
5 participants
@sverhoeven @bouweandela @mattiarighi @valeriupredoi @SarahAlidoost