Get rid of pytest-flake8 plugin #2897
Comments
5 tasks
schlunma
pushed a commit
that referenced
this issue
Nov 7, 2022
<!--
Thank you for contributing to our project!
Please do not delete this text completely, but read the text below and
keep
items that seem relevant. If in doubt, just keep everything and add your
own text at the top, a reviewer will update the checklist for you.
While the checklist is intended to be filled in by the technical and
scientific
reviewers, it is the responsibility of the author of the pull request to
make
sure all items on it are properly implemented.
-->
## Description
<!--
Please describe your changes here, especially focusing on why this pull
request makes
ESMValTool better and what problem it solves.
Before you start, please read our contribution guidelines:
https://docs.esmvaltool.org/en/latest/community/
Please fill in the GitHub issue that is closed by this pull request,
e.g. Closes #1903
-->
Sister PR to ESMValGroup/ESMValCore#1722 - quite
needed since the conda-forge package needed some involved pinning of the
flake8 and pytest-flake8 packages. Discussed this and @bouweandela
provided a working solution to the problem of the `pytest_flake8` plugin
being more and more at odds with the mother package `flake8`. Currently
the main `flake8` package (and only one as of this PR) is pinned to <5,
there are still some issues with upper versions but we should have in
mind to unpin and test in the future.
- Closes #2897
- Link to documentation: No need for it, no change to actual docs
* * *
## Before you get started
<!--
Please discuss your idea with the development team before getting
started,
to avoid disappointment or unnecessary work later. The way to do this is
to open a new issue on GitHub.
-->
- [x] [☝ Create an
issue](https://docs.esmvaltool.org/en/latest/community/code_documentation.html#contributing-code-and-documentation)
to discuss what you are going to do
## Checklist
It is the responsibility of the author to make sure the pull request is
ready to review. The icons indicate whether the item will be subject to
the [🛠 Technical][1] or [🧪 Scientific][2] review.
<!-- The next two lines turn the 🛠 and 🧪 below into hyperlinks -->
[1]:
https://docs.esmvaltool.org/en/latest/community/review.html#technical-review
[2]:
https://docs.esmvaltool.org/en/latest/community/review.html#scientific-review
- [x] [🛠][1] This pull request has a [descriptive
title](https://docs.esmvaltool.org/en/latest/community/code_documentation.html#pull-request-title)
- [x] [🛠][1] The [list of
authors](https://docs.esmvaltool.org/en/latest/community/code_documentation.html#list-of-authors)
is up to date
- [x] [🛠][1] Any changed dependencies have been [added or removed
correctly](https://docs.esmvaltool.org/en/latest/community/code_documentation.html#dependencies)
- [x] [🛠][1] All [checks below this pull
request](https://docs.esmvaltool.org/en/latest/community/code_documentation.html#pull-request-checks)
were successful
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The old issue tholo/pytest-flake8#87 bites us at conda pkg build stage see failed build so we need to get rid of
pytest-flake8plugin and just use the flake8 package as main flaker, as we do in ESMValCore. For now I've pinned both flake8 and pytest-flake8 in the conda feedstock meta, like we have in setup.py, but this is a bandaid and not a long term solution 👍The text was updated successfully, but these errors were encountered: