-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmorize cds uerra reanalysis #1275
Cmorize cds uerra reanalysis #1275
Conversation
I think you mean #237 |
I think you can just set the mip to one of the mips that contain 6 hourly data now. |
Can you please add an entry in Do we really need the |
We don't necessarily need |
If there are variables available in both datasets (i.e., both on pressure and soil levels), then renaming is necessary. Otherwise I think is redundant. |
There are no variables in both datasets. So we can go for Something else that I just came across while working with this dataset, is that |
In my version
|
Ok, since you have the latest version of the dataset, we should go with that. Can you change |
It goes through now, but it stops after the regridding since it cannot find the files to concatenate. I guess the problem is at these lines: ESMValTool/esmvaltool/cmorizers/obs/cmorize_obs_cds_uerra.py Lines 159 to 160 in aee3056
The files in the work_dir are named differently:
|
…ValGroup/ESMValTool into cmorize_cds-uerra-reanalysis
Yes, that should be changed as well, I just changed it. Of course it would be better to have the filenames inferred directly from the |
I understand, but this solution is quite error prone, since whatever variable you specify you always get the volumetric soil moisture to be concatenated. |
Ok, I can change it, but it will take a while, since I have to download the data again given that it has changed. |
I can send them to you via the DKRZ cloud if you wish (just a couple of years for testing). |
Yes, that sounds good :) CDS is offline now... |
Here you go (valid for 24 hours). |
I updated the script, ready for testing again ! |
Co-Authored-By: Mattia Righi <mattia.righi@dlr.de>
Can you solve the remaining codacy issue? |
Tested successfully! |
Open issue:
The
recipe_check_obs
complains about theFrequency
of the data. Thefrequency
is6h
, but the MIP isLmon
. How to make sure that the monthly frequency as read from MIP is overwritten by a user-defined custom frequency? I think @bouweandela recently raised this issue, but I couldn't find it somehow.