Conversation
…changing fill values.
…diag. reading daily data of era5 and era interim in thr globwat recipe
|
@banafsheh1992, I approve the review from a scientific perspective. |
Peter9192
left a comment
There was a problem hiding this comment.
Hi @babdollahi ,
Congratulations, the code looks very nice! I just have a couple of questions and small suggestions to help make it even clearer what exactly is going on.
|
|
@Peter9192 Your comments are addressed. Could you please have another look and perhaps approve it? thanks. |
Peter9192
left a comment
There was a problem hiding this comment.
Pre-emptive approval. Can you just add the references?
| 'ewatercycle', | ||
| ], | ||
| 'references': [ | ||
| 'acknow_project', |
There was a problem hiding this comment.
I think the reference is still missing
| 'ewatercycle', | ||
| ], | ||
| 'references': [ | ||
| 'acknow_project', |
There was a problem hiding this comment.
- debruin16ams
- hoogeveen15hess
- langbein1949usgs
References are added to the diagnostic script, too. |
|
@ESMValGroup/esmvaltool-coreteam This pull request is approved by scientific and technical reviewers. Could you please merge it? Thank you. |
Before you start, please read our contribution guidelines.
Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.
Tasks
yamllintto check that your YAML files do not contain mistakesNew recipe/diagnostic
doc/sphinx/source/recipesfolder and add a new entry to index.rstModified recipe/diagnostic
doc/sphinx/source/recipesfolderNew data reformatting script
Modified data reformatting script
If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #issue_number