Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GlobWat recipe and diagnostic #1808

Merged
merged 124 commits into from Jun 21, 2021
Merged

Add GlobWat recipe and diagnostic #1808

merged 124 commits into from Jun 21, 2021

Conversation

babdollahi
Copy link
Contributor

@babdollahi babdollahi commented Sep 8, 2020

Before you start, please read our contribution guidelines.

Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.


Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • (Only if really necessary) Add any additional dependencies needed for the diagnostic script to setup.py, esmvaltool/install/R/r_requirements.txt or esmvaltool/install/Julia/Project.toml (depending on the language of your script) and also to package/meta.yaml for conda dependencies (includes Python and others, but not R/Julia)
  • If new dependencies are introduced, check that the license is compatible with Apache2.0

New recipe/diagnostic

  • Add documentation for the recipe to the doc/sphinx/source/recipes folder and add a new entry to index.rst
  • Add provenance information

Modified recipe/diagnostic

  • Update documentation for the recipe to the doc/sphinx/source/recipes folder
  • Update provenance information if needed
  • Assign the author(s) of the affected recipe(s) as reviewer(s)

New data reformatting script

  • Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
  • Add the new dataset to the table in the documentation
  • Tag @mattiarighi in this pull request, so that the new dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

Modified data reformatting script

  • Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
  • Tag @mattiarighi in this pull request, so that the updated dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #issue_number

…diag.

reading daily data of era5 and era interim in thr globwat recipe
@jeromaerts
Copy link
Contributor

@banafsheh1992, I approve the review from a scientific perspective.

Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @babdollahi ,
Congratulations, the code looks very nice! I just have a couple of questions and small suggestions to help make it even clearer what exactly is going on.

doc/sphinx/source/recipes/recipe_hydrology.rst Outdated Show resolved Hide resolved
esmvaltool/recipes/hydrology/recipe_globwat.yml Outdated Show resolved Hide resolved
esmvaltool/recipes/hydrology/recipe_globwat.yml Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/hydrology/globwat.py Show resolved Hide resolved
esmvaltool/diag_scripts/hydrology/globwat.py Show resolved Hide resolved
esmvaltool/diag_scripts/hydrology/globwat.py Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/hydrology/globwat.py Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/hydrology/globwat.py Outdated Show resolved Hide resolved
@babdollahi
Copy link
Contributor Author

Hi @babdollahi ,
Congratulations, the code looks very nice! I just have a couple of questions and small suggestions to help make it even clearer what exactly is going on.
Hi @Peter9192, Thanks for reviewing the code and your comments

SarahAlidoost and others added 2 commits June 21, 2021 10:58
Co-authored-by: Peter Kalverla <peter.kalverla@gmx.com>
@SarahAlidoost
Copy link
Contributor

@Peter9192 Your comments are addressed. Could you please have another look and perhaps approve it? thanks.

Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-emptive approval. Can you just add the references?

'ewatercycle',
],
'references': [
'acknow_project',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reference is still missing

'ewatercycle',
],
'references': [
'acknow_project',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- debruin16ams
- hoogeveen15hess
- langbein1949usgs

@SarahAlidoost
Copy link
Contributor

Pre-emptive approval. Can you just add the references?

References are added to the diagnostic script, too.

@SarahAlidoost
Copy link
Contributor

@ESMValGroup/esmvaltool-coreteam This pull request is approved by scientific and technical reviewers. Could you please merge it? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants