Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release schedule #1948

Merged
merged 4 commits into from
Dec 21, 2020
Merged

Update release schedule #1948

merged 4 commits into from
Dec 21, 2020

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Dec 8, 2020

This updates the release schedule with past releases, thus highlighting the next upcoming release.

Closes #1947


Checklist for technical review

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • The pull request has a descriptive title that can be used as a one line summary in the changelog
  • Documentation is available
  • Circle/CI tests pass. If the tests are failing, click the Details link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • The documentation is building successfully on readthedocs and looks well formatted, click the Details link to see it.

@zklaus
Copy link
Contributor Author

zklaus commented Dec 8, 2020

This depends on ESMValGroup/ESMValCore#899 to provide labels for the links to the core changelog. When that is merged, we can fix the circleci complaints about the missing link target.

Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
@zklaus
Copy link
Contributor Author

zklaus commented Dec 9, 2020

Hmm. The links to the core changelog don't appear quite right, though the build error is gone. Not sure what's going on. One of you sphinx gurus have an opinion or advice?

@zklaus
Copy link
Contributor Author

zklaus commented Dec 9, 2020

@nielsdrost could you update the illustration? If it's easy to do. Otherwise, we'll keep it as an example and perhaps update it later.

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Dec 9, 2020

@nielsdrost could you update the illustration? If it's easy to do. Otherwise, we'll keep it as an example and perhaps update it later.

I suggested in the issue to have the code that plots that plot with release goal posts be included in the utils or something; if not I might write a code that plots those, but you may regret that since the moving targets for the next releases may be tanks 😀

@valeriupredoi
Copy link
Contributor

cheers @zklaus - I'll have a looksee myself tomorrow 👍

@bouweandela
Copy link
Member

Hmm. The links to the core changelog don't appear quite right, though the build error is gone. Not sure what's going on. One of you sphinx gurus have an opinion or advice?

You're the sphinx guru here @zklaus, I didn't know you could make the links like that! It looks great to me, maybe it just looks wrong because of some caching? sometimes it helps if you add a ? followed by some random characters to the URL to trick the page into reloading.

@zklaus
Copy link
Contributor Author

zklaus commented Dec 10, 2020

You are right, now it looks ok also for me; probably some caching issue. Last thing is then @nielsdrost's graphic, otherwise, I am happy with this PR.

@valeriupredoi
Copy link
Contributor

finally got around to generate the dox and have a look - very nice! Lots of useful info 👍 🍺

@zklaus
Copy link
Contributor Author

zklaus commented Dec 14, 2020

Seems Niels is busy or on Christmas break already. Since the figure is clearly labeled as an example, I suggest merging this PR as-is and setting up a workflow for updating the graphic for every future release separately.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bouweandela is on hols too and I will be gonzo from tomorrow myself, so my last PR approval of the year 🎅

@jvegreg jvegreg merged commit f61cb16 into master Dec 21, 2020
@jvegreg jvegreg deleted the update-release-schedule branch December 21, 2020 10:08
@zklaus zklaus mentioned this pull request Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release schedule to reflect past events
4 participants