Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core team info #1973

Merged
merged 5 commits into from Jan 27, 2021
Merged

Update core team info #1973

merged 5 commits into from Jan 27, 2021

Conversation

axel-lauer
Copy link
Contributor

@axel-lauer axel-lauer commented Jan 12, 2021

This PR updates the contact info and members of the Core Team. The correspondin PR for ESMValCore is ESMValGroup/ESMValCore#942

  • CODE_OF_CONDUCT.md
  • NOTICE - might need more revisions
  • introduction.rst

@axel-lauer
Copy link
Contributor Author

axel-lauer commented Jan 13, 2021

@ESMValGroup/esmvaltool-coreteam The file NOTICE contains a list of recipes and institutes having the copyright. Do we want to keep this list? If so, this list needs some updates to also include more recent recipes.

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file NOTICE contains a list of recipes and institutes having the copyright.

That is bound to happen is the information is kept separate from the actual recipes. If we want to keep this information, we could add a copyright key to the documentation section of the recipes instead? That is far more likely to stay in sync, but even then I'm not sure if this will really work out, because over time people from multiple institutions tend to contribute to a recipe/diagnostic.


- ESMValTool Core PI and Developer: contact for requests to use the ESMValTool and for collaboration with the development team, access to the PRIVATE GitHub repository.
- ESMValTool Core Co-PI and Developer: contact for requests to use the ESMValTool and for collaboration with the development team, access to the PRIVATE GitHub repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be a bit more clear if this sentence was not nested in the list of participating institutions? Adding the email addresses mentioned in the NOTICE file would also make it more clear.

Copy link
Contributor

@hb326 hb326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me.

@@ -14,7 +14,8 @@ Copyright 2008- Deutsches Zentrum für Luft- und Raumfahrt e.V. (DLR) and partne
==========================================
(1) ESMValTool VERSION 2.0 CORE DEVELOPMENT TEAM
==========================================
Copyright 2008- Deutsches Zentrum für Luft- und Raumfahrt e.V. (DLR), Germany - ESMValTool Principal Investigator (PI)
Copyright 2008- Deutsches Zentrum für Luft- und Raumfahrt e.V. (DLR), Germany - ESMValTool Co-PI
Copyright 2020- Met Office, UK - ESMValTool Co-PI
Copyright 2017- Alfred-Wegener-Institute (AWI), Germany
Copyright 2017- Barcelona Supercomputing Center (BSC), Spain
Copyright 2016- Ludwig Maximilian University, Germany
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright 2016- Ludwig Maximilian University, Germany
Copyright 2016- Ludwig Maximilian University, Germany
Copyright 2011- Swedish Meteorological and Hydrological Institute (SMHI), Sweden

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this line should be added a bit lower, below Copyright 2019- Plymouth..., but I couldn't comment there in the github GUI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@axel-lauer axel-lauer marked this pull request as ready for review January 21, 2021 14:59
@axel-lauer axel-lauer merged commit e2341cc into master Jan 27, 2021
@axel-lauer axel-lauer deleted the update_core_team_info branch January 27, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants