Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

retire test with Python 3.6 from full development Github Actions test #2229

Merged
merged 1 commit into from Jul 30, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jul 12, 2021

Description

Pinning cf-units>=3.0 in the development environment for ESMValCore makes the environment unsolvable for Python 3.6. This is fine, since we will be retiring support for Python 3.6 in 2.4, but the GA full dev test fails. This would be an unexpected behavior for any user that wants to use ESMValTool in full development mode, forcing Python 3.6 in their environment, but chances that happens are close to nil so I don't think we should say anything in the documentation?


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.


To help with the number of pull requests:

@zklaus
Copy link
Contributor

zklaus commented Jul 12, 2021

The pin to cfunits>=3 is already in effect, right? Is this fine? Does that mean we should retire Python 3.6 already with ESMValTool 2.3.0? Do we need a working lower pin for now?

@ESMValGroup/esmvaltool-coreteam, do you have some opinion on this?

@valeriupredoi
Copy link
Contributor Author

we've not retired it officially in ESMValCore but that pin makes it virtually impossible to get a Py3.6 env done for ESMValCore in development mode (we don't even have the nightly GA test for Py 3.6 https://github.com/ESMValGroup/ESMValCore/actions/runs/1021187064 anymore). It is, however, possible to still have Py3.6 with the released ESMValCore 2.3.0 hence with the future release of ESMValTool too, just not with ESMValCore installed from the latest development branch

@bouweandela bouweandela merged commit a5ceb7f into main Jul 30, 2021
@bouweandela bouweandela deleted the retire_py36_fromGADevTest branch July 30, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants