retire test with Python 3.6 from full development Github Actions test #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pin to @ESMValGroup/esmvaltool-coreteam, do you have some opinion on this? |
|
we've not retired it officially in ESMValCore but that pin makes it virtually impossible to get a Py3.6 env done for ESMValCore in development mode (we don't even have the nightly GA test for Py 3.6 https://github.com/ESMValGroup/ESMValCore/actions/runs/1021187064 anymore). It is, however, possible to still have Py3.6 with the released ESMValCore 2.3.0 hence with the future release of ESMValTool too, just not with ESMValCore installed from the latest development branch |
bouweandela
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pinning
cf-units>=3.0in the development environment for ESMValCore makes the environment unsolvable for Python 3.6. This is fine, since we will be retiring support for Python 3.6 in 2.4, but the GA full dev test fails. This would be an unexpected behavior for any user that wants to use ESMValTool in full development mode, forcing Python 3.6 in their environment, but chances that happens are close to nil so I don't think we should say anything in the documentation?Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number of pull requests: