-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More removals of instances of write_plots
from Python diagnostics (appears to be the final removal from Py diags)
#2394
Conversation
@@ -49,7 +49,7 @@ def get_provenance_record(gatt, vatt, ancestor_files): | |||
def main(cfg): | |||
"""Ensemble Clustering Diagnostics.""" | |||
out_dir = cfg['work_dir'] | |||
write_plots = cfg['write_plots'] | |||
write_plots = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? I would remove it and see if the diagnostic still works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah could do, didn't want to temper too much with the diag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, tis history now 🏴☠️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, changed my mind a bit. Let's add the remaining diags as well. More comments to come.
The seaice feedback diagnostic uses the constant from here---which probably should go as well. |
I'll tackle the R diagnostics separately, if you also address here
Deal? |
OK will do but I don't speak NCL so that's why I'm looking only at 🐍 diags |
Aren't all the ones I listed snakey? |
yesh they are, on it now, bud! |
OK done! removed all |
write_plots
from Python diagnosticswrite_plots
from Python diagnostics (appears to be the final removal from Py diags)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
thanks dude, not the most pleasant PR to review 😆 |
Description
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.