More removals of instances of write_plots from Python diagnostics (appears to be the final removal from Py diags)#2394
Conversation
| """Ensemble Clustering Diagnostics.""" | ||
| out_dir = cfg['work_dir'] | ||
| write_plots = cfg['write_plots'] | ||
| write_plots = True |
There was a problem hiding this comment.
Is this needed? I would remove it and see if the diagnostic still works.
There was a problem hiding this comment.
yeah could do, didn't want to temper too much with the diag
There was a problem hiding this comment.
done, tis history now 🏴☠️
zklaus
left a comment
zklaus
left a comment
There was a problem hiding this comment.
Sorry, changed my mind a bit. Let's add the remaining diags as well. More comments to come.
|
The seaice feedback diagnostic uses the constant from here---which probably should go as well. |
|
I'll tackle the R diagnostics separately, if you also address here
Deal? |
|
OK will do but I don't speak NCL so that's why I'm looking only at 🐍 diags |
|
Aren't all the ones I listed snakey? |
|
yesh they are, on it now, bud! |
|
OK done! removed all |
valeriupredoi
changed the title
write_plots from Python diagnosticswrite_plots from Python diagnostics (appears to be the final removal from Py diags)
|
thanks dude, not the most pleasant PR to review 😆 |
2 participants
Description
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.