Ignore .pymon-journal file in test discovery #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zklaus
force-pushed
the
ignore-pymon-journal
branch
from
f9e9ecf
to
d58ad09
Compare
|
@valeriupredoi, good idea with the full path. I changed the Linux path because it is different from the Mac path; let's see. |
valeriupredoi
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
cheers @zklaus good catch about the OSX path, they gotta be different for everything don't they 🍎
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes (relatively frequently), the monitor tests fail because pytests discovery stumbles over what looks like a temporary file from pytest-monitor. This PR adds an explicit ignore for that file.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number of pull requests: