Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-establish Python 3.7 compatibility #2506

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Jan 31, 2022

Description

When adding provenance to the diagnostic script, I made use of the walrus operator (:=) which was introduced in Python 3.8.
Since we seem to still be supporting Python 3.7, this is reformulated here with a compatible version. Use of pre-commit hooks also triggered a few reformats and the fixing of some typos.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested the recipe once more. Works fine, provenance output also looks fine.

@zklaus zklaus added the bug label Jan 31, 2022
@zklaus zklaus merged commit d66cc59 into main Jan 31, 2022
@zklaus zklaus deleted the make-python-37-compatible branch January 31, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants