Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix indexer in Autoassess supermeans module use a tuple of (slice(), idx, idx) #2838

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 7, 2022

Description

Found while running diags for release in #2833 - the indexer was a list like list[slice(), idx, idx] which is deprecated, and now fully retired behaviour, but a tuple of that is well liked by Numpy. Can I gets a quick a-ok here plese much? 🍺

Closes #2837


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

Copy link
Contributor

@sloosvel sloosvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recipes finish successfully with this change, but maybe someone more familiar with the results should check if they are consistent

@valeriupredoi
Copy link
Contributor Author

cheers muchly @sloosvel - not a worry, this module (the supermeans one) will be retired soon, plus, the tuple of slice, index, index is identical to what was previously a list of the same elements, so the output array is identical. Gonna merge 🍺

@valeriupredoi valeriupredoi merged commit 93c9792 into main Oct 10, 2022
@valeriupredoi valeriupredoi deleted the fix_aa_supermeans branch October 10, 2022 11:22
mo-tgeddes added a commit that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couple Autoassess recipes failing
2 participants