Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added reference entry for Winterstein #3154

Merged
merged 5 commits into from Apr 13, 2023

Conversation

FranziskaWinterstein
Copy link
Contributor

@FranziskaWinterstein FranziskaWinterstein commented Apr 11, 2023

Description

Hello,

to be able to put myself with my new family name as reference in recipes and diagnostics, I added the entry winterstein_franziska to config-references.yml.

I did not delete the entry frank_franziska at least for now. If need be, I can update all diagnostics and recipes I am referenced with frank_franziska and delete that entry. What do you think?

Checklist

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for updating config-references.yml! Theoretically, the list of developers is (more or less) sorted alphabetically, so you could move your new entry a bit more to the bottom of the list if you like.

Regarding changing existing code, I would say that's up to you. I am fine either way. In a similar case in the past, we did not change old code but that was mainly because we also had recipes including the author's name (which should not be changed as the corresponding publication is called like this, but I believe is not yet the case here).

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers Franziska and Axel 🍺

@valeriupredoi valeriupredoi merged commit 6948d55 into main Apr 13, 2023
6 checks passed
@valeriupredoi valeriupredoi deleted the add_franziska_winterstein_references branch April 13, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants