Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python=3.11 #3173

Merged
merged 23 commits into from Jun 6, 2023
Merged

Add support for Python=3.11 #3173

merged 23 commits into from Jun 6, 2023

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented May 10, 2023

Add support for Python 3.11

Add support for Python 3.11 by updating pins and changing the documentation theme to a more modern theme that supports Python 3.11.

History

This is THERE NOW 馃榿

This is the sister PR of Core's ESMValGroup/ESMValCore#1832 which that works fine.

All needed tasks are now completed! As for testing - all goes fine, including

Strategy

This needs be discussed: currently this works fine with esmvalcore=2.8.1rc1 but as the name of the package suggests, it's a very RC of a bugfix release that's not there yet; pending @remi-kazeroni 's testing we may release a Core bugfix release; regardless of that, @ESMValGroup/technical-lead-development-team I suppose Tool with Py311 support will only beavailable at 2.9 release point right? Please comment below about this. If that's the case then I'll have to keep maintaining this by running periodical GA tests see anything breaks the show in the meantime. -> result of discussion: esmvalcore v2.8.1 has been released ESMValGroup/ESMValCore#2081.

Steps undertaken to make the blithering thing work (historical stuff)

That's it! env for Python=311 building nicely, bar, of course, esmvalcore that needs a conda rebuild/release - we have core=2.8.1rc1 and env builds well, @remi-kazeroni is currently running recipe tests too, with it. As of now (22 May 2023) there are a couple issues from CI:

  • xesmf is pinned to ancient and barfs with the ne ESMF->esmpy type of import shoutout to @zklaus who fixe-ed this 馃嵑 xesmf=0.7.1 now be in the environment, and good things happen

Now, couple more issues:

As of May 23rd, 2023: all systems are go!

Still to do: get all the CI workflows to run Python=3.11

@bouweandela
Copy link
Member

The installation is failing now because it picks up ESMValCore v2.7.1 instead of v2.8.

@valeriupredoi
Copy link
Contributor Author

Well, we've not rebuilt and deployed Core yet, the solver is a bit confused, will take it from here, now that that psy pkg is rebuilt for 3.11

@bouweandela
Copy link
Member

Comment by @zklaus

In ESMValCore v2.8 setup.py we have a pin on esmpy<8.4, but that is not available for Python 3.11. From 8.4.2 onward, esmpy is noarch.

@valeriupredoi
Copy link
Contributor Author

yes, that's why I'll go straight to Core feedstock and get us a build=1 done with the new pins, that will allow the installation of new 311-fangled deps 馃憤

@valeriupredoi
Copy link
Contributor Author

@bouweandela @remi-kazeroni @zklaus we are well and truly in Python=3.11 business, gents 馃悕 馃榿

@valeriupredoi valeriupredoi marked this pull request as ready for review May 23, 2023 16:12
@valeriupredoi valeriupredoi added this to the v2.9.0 milestone May 24, 2023
@bouweandela bouweandela changed the title [Python] Add support for Python=3.11 Add support for Python=3.11 Jun 6, 2023
@bouweandela bouweandela merged commit 377f3c1 into main Jun 6, 2023
6 checks passed
@bouweandela bouweandela deleted the python311 branch June 6, 2023 10:57
@valeriupredoi
Copy link
Contributor Author

woohoo, progressumpossum! Cheers @bouweandela 馃嵒

jvegreg pushed a commit that referenced this pull request Jan 14, 2024
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants