Fix failing mlr diagnostic test by adding new scikit-learn default tag
#3273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-kazeroni
requested review from
zklaus,
bouweandela,
valeriupredoi and
schlunma
5 tasks
valeriupredoi
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
(draft PR approval, Klaus, keep your watch on 😆 ) Fine by me too - I still think we need to not close the test failure issue with whatever PR we merge, and let @schlunma decide what's the best approach to handle this (he might want to add additional test cases or code features). Also this was nowhere in the scikit-learn Changelog for 1.3.0 (unless I missed it), so am not even sure if the breaking behavior we see is supposed to be like this. TL;DR: am suspicious 😁
Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
zklaus
approved these changes
Jul 4, 2023
zklaus
changed the title
mlr diagnostic test by adding missing tagmlr diagnostic test by adding new scikit-learn default tag
bouweandela
added a commit
that referenced
this pull request
Jul 4, 2023
…tag (#3273) Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl> Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
jvegreg
pushed a commit
that referenced
this pull request
Jan 14, 2024
…tag (#3273) Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl> Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Second attempt to fix the failing test
test_safe_tags_no_get_tags. An additional tagarray_api_supportwas added to the list ofDEFAULT_TAGSin the dependency (scikit-learn 1.3.0) and this needs to be reflected in our code.Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number of pull requests: