Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[condalock] update conda lock creation Github Action workflow and ship updated (bot-generated) conda-lock file #3307

Merged
merged 5 commits into from Aug 2, 2023

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jul 24, 2023

Description

The conda-lock file creation currently fails because our conda/mamba combo is too old to handle installing the updated version of conda-lock (as it comes shipped with setup-miniconda@v2, despite a forced conda base update); this solves the problem by forcing a very new mamba, which, in turn, updates conda too; this has been done in ESMValCore in ESMValGroup/ESMValCore#2136

In addition to this, I have now set the shell at the very top of the workflow file, and doing that just once, w/o the need to specify the shell for every run step. As described in #3279 (still to be done for the other workflows, this is just for the conda-lock flow).

This was tested in this test run that correctly produced a bot PR #3309 that I will now merge here so we ship this PR with an updated conda lock file too (verified and looked at by yours truly).


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

@valeriupredoi valeriupredoi changed the title [condalock] update conda lock creation Github Action workflow [condalock] update conda lock creation Github Action workflow and ship updated (bot-generated) conda-lock file Jul 24, 2023
@valeriupredoi
Copy link
Contributor Author

@bouweandela since you back from 🏖️ maybe you could give this a review pls bud - our lockfile is getting 👴

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@valeriupredoi
Copy link
Contributor Author

tak @bouweandela 🍺

@valeriupredoi valeriupredoi merged commit 9485a64 into main Aug 2, 2023
6 checks passed
@valeriupredoi valeriupredoi deleted the update_condalock_create branch August 2, 2023 11:49
ehogan added a commit that referenced this pull request Aug 30, 2023
…_RTW

* recipe_test_workflow_prototype: (237 commits)
  Add version to dataset in python example recipe to avoid "Unknown file format" issue on JASMIN (#3322)
  CMORizer for NASA MERRA reanalysis (#3039)
  Add `OBS-maintainers` team to documentation on OBS data maintenance and CMORizer reviews (#3335)
  Fixed provenance tracking for NCL multipanel PNGs (#3332)
  Cmorizer for NOAA-CIRES-20CR v3 reanalysis (clt, clwvi, hus, prw, rlut, rlutcs, rsut, rsutcs) (#3137)
  [Condalock] Update Linux condalock file (#3321)
  Slight refactoring of diag `galytska23/select_variables_for_tigramite.py` for generality and portability (for Changelog v2.10: authors: @valeriupredoi and @egalytska) (#3298)
  Removed recipe_carvalhais14nat from list of broken recipes (#3319)
  add Romain Beucher to CITATION as contributor (#3318)
  update `mamba` version in readthedocs configuration docs builds (#3310)
  [Github Actions] Compress all bash shell setters into one default option per workflow (#3315)
  [condalock] update conda lock creation Github Action workflow and ship updated (bot-generated) conda-lock file (#3307)
  Allow NCL unit conversion `kg s-1` -> `GtC y-1` (#3300)
  Add list of failing recipes for v2.9.0 release (#3294)
  Update diag_shapeselect.py to work with shapely v2 (#3283)
  Update release schedule after release of v2.9.0 (#3289)
  Add merge instructions to release instructions (#3292)
  Made sklearn test backwards-compatible with sklearn < 1.3 (#3285)
  Add release notes for v2.9 (#3266)
  Add release notes for v2.9 (#3266)
  ...
jvegreg pushed a commit that referenced this pull request Jan 14, 2024
…p updated (bot-generated) conda-lock file (#3307)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: valeriupredoi <valeriupredoi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New conda-lock=2.1.0 fails to build lockfile
2 participants