Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OBS-maintainers team to documentation on OBS data maintenance and CMORizer reviews #3335

Merged
merged 5 commits into from Aug 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
@@ -1,2 +1,2 @@
esmvaltool/cmorizers @remi-kazeroni
esmvaltool/cmorizers @ESMValGroup/obs-maintainers
.github/workflows @valeriupredoi
1 change: 1 addition & 0 deletions .github/pull_request_template.md
Expand Up @@ -62,6 +62,7 @@ It is the responsibility of the author to make sure the pull request is ready to

- [ ] [🛠][1] [Documentation](https://docs.esmvaltool.org/en/latest/community/dataset.html#dataset-documentation) is available
- [ ] [🛠][1] The dataset has been [added to the CMOR check recipe](https://docs.esmvaltool.org/en/latest/community/dataset.html#testing)
- [ ] [🛠][1] The dataset has been added to the shared [data pools](https://docs.esmvaltool.org/en/latest/community/dataset.html#cmorized-data) of DKRZ and Jasmin by the @ESMValGroup/OBS-maintainers team
- [ ] [🧪][2] Numbers and units of the data look [physically meaningful](https://docs.esmvaltool.org/en/latest/community/dataset.html#scientific-sanity-check)

***
Expand Down
10 changes: 5 additions & 5 deletions doc/sphinx/source/community/dataset.rst
Expand Up @@ -65,10 +65,10 @@ The scientific reviewer needs to check this.
Data availability
=================

Once your pull request has been approved by the reviewers, ask
`@remi-kazeroni <https://github.com/remi-kazeroni>`_
Once your pull request has been approved by the reviewers, ask a member of
`@OBS-maintainers <https://github.com/orgs/ESMValGroup/teams/obs-maintainers>`_
to add the new dataset to the data pool at DKRZ and CEDA-Jasmin.
He is also the person in charge of merging CMORizer pull requests.
This team is in charge of merging CMORizer pull requests.

.. _dataset_checklist:

Expand Down Expand Up @@ -165,14 +165,14 @@ Run ``esmvaltool/recipes/examples/recipe_check_obs.yml`` for new dataset.
RAW data
--------

Contact person in charge of ESMValTool data pool (`@remi-kazeroni`_) and
Contact the team in charge of ESMValTool data pool (`@OBS-maintainers`_) and
request to copy RAW data to RAWOBS/Tier2 (Tier3).


CMORized data
-------------

Contact person in charge of ESMValTool data pool (`@remi-kazeroni`_) and
Contact the team in charge of ESMValTool data pool (`@OBS-maintainers`_) and
request to

* Merge the pull request
Expand Down
4 changes: 2 additions & 2 deletions doc/sphinx/source/community/review.rst
Expand Up @@ -69,7 +69,7 @@ GitHub.

Pull requests are merged by the `@ESMValGroup/esmvaltool-coreteam`_.
Specifically, pull requests containing a :ref:`CMORizer script<new-dataset>` can only be merged by
`@remi-kazeroni`_, who will then add the CMORized data to the OBS data pool at
a member of `@OBS-maintainers`_, who will then add the CMORized data to the OBS data pool at
DKRZ and CEDA-Jasmin.
The team member who does the merge first checks that both the technical and
scientific reviewer approved the pull request and that the reviews were
Expand Down Expand Up @@ -215,7 +215,7 @@ their opinion and try to find a solution.
.. _`@ESMValGroup/tech-reviewers`: https://github.com/orgs/ESMValGroup/teams/tech-reviewers
.. _`@ESMValGroup/science-reviewers`: https://github.com/orgs/ESMValGroup/teams/science-reviewers
.. _`@ESMValGroup/esmvaltool-coreteam`: https://github.com/orgs/ESMValGroup/teams/esmvaltool-coreteam
.. _`@remi-kazeroni`: https://github.com/remi-kazeroni
.. _`@OBS-maintainers`: https://github.com/orgs/ESMValGroup/teams/obs-maintainers
.. _`pull request template`: https://raw.githubusercontent.com/ESMValGroup/ESMValTool/main/.github/pull_request_template.md
.. _`Google meet`: https://meet.google.com
.. _`Jitsi meet`: https://meet.jit.si
Expand Down