Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe changes for new statistics preprocessors (percentiles) #3351

Merged
merged 5 commits into from Nov 8, 2023

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Sep 7, 2023

Description

This PR adapts recipes in light of ESMValGroup/ESMValCore#2191. Needs a new ESMValCore release to work. The output of the new recipes is identical with the old versions.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@schlunma schlunma added diagnostic requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. labels Sep 7, 2023
@schlunma schlunma added this to the v2.10.0 milestone Sep 7, 2023
@schlunma schlunma self-assigned this Sep 7, 2023
@zklaus
Copy link
Contributor

zklaus commented Nov 3, 2023

@schlunma, could you please comment on the status of this PR? It looks fine to me, but I am not sure if you wanted to add other recipe changes or if it is in draft state simply due to the awaited core release.

@bouweandela bouweandela marked this pull request as ready for review November 8, 2023 07:43
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just merge this as is and then more changes can be added later.

@bouweandela bouweandela merged commit 9293c00 into main Nov 8, 2023
7 checks passed
@bouweandela bouweandela deleted the adapt_percentile_preprocs branch November 8, 2023 07:44
@schlunma
Copy link
Contributor Author

schlunma commented Nov 9, 2023

Yes, this PR was ready from my side. Thanks for merging it!

I noticed that since opening this PR another recipe has been added in #3356 that uses the deprecated syntax. @bouweandela, since you are the author of that recipe, would you be able to adapt the recipe and the diagnostics to the new syntax? Thanks!!

jvegreg pushed a commit that referenced this pull request Jan 14, 2024
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostic requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants